Browse Source

Fix few comments in validate scripts

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Vincent Demeester 9 years ago
parent
commit
1ce9be346b
4 changed files with 2 additions and 4 deletions
  1. 0 1
      hack/make/validate-lint
  2. 1 1
      hack/make/validate-test
  3. 1 1
      hack/make/validate-toml
  4. 0 1
      hack/make/validate-vet

+ 0 - 1
hack/make/validate-lint

@@ -8,7 +8,6 @@ unset IFS
 
 errors=()
 for f in "${files[@]}"; do
-	# we use "git show" here to validate that what's committed passes go vet
 	failedLint=$(golint "$f")
 	if [ "$failedLint" ]; then
 		errors+=( "$failedLint" )

+ 1 - 1
hack/make/validate-test

@@ -15,7 +15,7 @@ for f in "${files[@]}"; do
 		continue
 	fi
 
-	# we use "git show" here to validate that what's committed is formatted
+	# we use "git show" here to validate that what's committed doesn't contain golang built-in testing
 	if git show "$VALIDATE_HEAD:$f" | grep -q testing.T; then
 		badFiles+=( "$f" )
 	fi

+ 1 - 1
hack/make/validate-toml

@@ -8,7 +8,7 @@ unset IFS
 
 badFiles=()
 for f in "${files[@]}"; do
-	# we use "git show" here to validate that what's committed is formatted
+	# we use "git show" here to validate that what's committed has valid toml syntax
 	if ! git show "$VALIDATE_HEAD:$f" | tomlv /proc/self/fd/0 ; then
 		badFiles+=( "$f" )
 	fi

+ 0 - 1
hack/make/validate-vet

@@ -8,7 +8,6 @@ unset IFS
 
 errors=()
 for f in "${files[@]}"; do
-	# we use "git show" here to validate that what's committed passes go vet
 	failedVet=$(go vet "$f")
 	if [ "$failedVet" ]; then
 		errors+=( "$failedVet" )