Browse Source

daemon/config: error strings should not be capitalized

    daemon/config/config_unix.go:92:21: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
            return fmt.Errorf("Default cgroup namespace mode (%v) is invalid. Use \"host\" or \"private\".", cm) // nolint: golint
                              ^

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sebastiaan van Stijn 4 years ago
parent
commit
16ced7622b
1 changed files with 4 additions and 4 deletions
  1. 4 4
      daemon/config/config_unix.go

+ 4 - 4
daemon/config/config_unix.go

@@ -74,14 +74,14 @@ func (conf *Config) IsSwarmCompatible() error {
 }
 }
 
 
 func verifyDefaultIpcMode(mode string) error {
 func verifyDefaultIpcMode(mode string) error {
-	const hint = "Use \"shareable\" or \"private\"."
+	const hint = `use "shareable" or "private"`
 
 
 	dm := containertypes.IpcMode(mode)
 	dm := containertypes.IpcMode(mode)
 	if !dm.Valid() {
 	if !dm.Valid() {
-		return fmt.Errorf("Default IPC mode setting (%v) is invalid. "+hint, dm)
+		return fmt.Errorf("default IPC mode setting (%v) is invalid; "+hint, dm)
 	}
 	}
 	if dm != "" && !dm.IsPrivate() && !dm.IsShareable() {
 	if dm != "" && !dm.IsPrivate() && !dm.IsShareable() {
-		return fmt.Errorf("IPC mode \"%v\" is not supported as default value. "+hint, dm)
+		return fmt.Errorf(`IPC mode "%v" is not supported as default value; `+hint, dm)
 	}
 	}
 	return nil
 	return nil
 }
 }
@@ -89,7 +89,7 @@ func verifyDefaultIpcMode(mode string) error {
 func verifyDefaultCgroupNsMode(mode string) error {
 func verifyDefaultCgroupNsMode(mode string) error {
 	cm := containertypes.CgroupnsMode(mode)
 	cm := containertypes.CgroupnsMode(mode)
 	if !cm.Valid() {
 	if !cm.Valid() {
-		return fmt.Errorf("Default cgroup namespace mode (%v) is invalid. Use \"host\" or \"private\".", cm) //nolint: golint
+		return fmt.Errorf(`default cgroup namespace mode (%v) is invalid; use "host" or "private"`, cm)
 	}
 	}
 
 
 	return nil
 	return nil