Переглянути джерело

Don't error with empty group

Don't error if no group is specified, as this was the prior API.  Also
don't return a docker specific error message as this is in `/pkg` and
used by other projects.  Just set the default group for the current
user/group consuming the package.

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
Michael Crosby 8 роки тому
батько
коміт
169c013911
2 змінених файлів з 10 додано та 6 видалено
  1. 5 3
      pkg/listeners/listeners_solaris.go
  2. 5 3
      pkg/listeners/listeners_unix.go

+ 5 - 3
pkg/listeners/listeners_solaris.go

@@ -22,10 +22,12 @@ func Init(proto, addr, socketGroup string, tlsConfig *tls.Config) (ls []net.List
 	case "unix":
 	case "unix":
 		gid, err := lookupGID(socketGroup)
 		gid, err := lookupGID(socketGroup)
 		if err != nil {
 		if err != nil {
-			if socketGroup != defaultSocketGroup {
-				return nil, err
+			if socketGroup != "" {
+				if socketGroup != defaultSocketGroup {
+					return nil, err
+				}
+				logrus.Warnf("could not change group %s to %s: %v", addr, defaultSocketGroup, err)
 			}
 			}
-			logrus.Warnf("could not change group %s to %s: %v", addr, defaultSocketGroup, err)
 			gid = os.Getgid()
 			gid = os.Getgid()
 		}
 		}
 		l, err := sockets.NewUnixSocket(addr, gid)
 		l, err := sockets.NewUnixSocket(addr, gid)

+ 5 - 3
pkg/listeners/listeners_unix.go

@@ -35,10 +35,12 @@ func Init(proto, addr, socketGroup string, tlsConfig *tls.Config) ([]net.Listene
 	case "unix":
 	case "unix":
 		gid, err := lookupGID(socketGroup)
 		gid, err := lookupGID(socketGroup)
 		if err != nil {
 		if err != nil {
-			if socketGroup != defaultSocketGroup {
-				return nil, err
+			if socketGroup != "" {
+				if socketGroup != defaultSocketGroup {
+					return nil, err
+				}
+				logrus.Warnf("could not change group %s to %s: %v", addr, defaultSocketGroup, err)
 			}
 			}
-			logrus.Warnf("could not change group %s to %s: %v", addr, defaultSocketGroup, err)
 			gid = os.Getgid()
 			gid = os.Getgid()
 		}
 		}
 		l, err := sockets.NewUnixSocket(addr, gid)
 		l, err := sockets.NewUnixSocket(addr, gid)