浏览代码

Merge pull request #2450 from TheNodi/iptables-policy

Always configure iptables forward policy
Euan Harris 5 年之前
父节点
当前提交
141b53c77a
共有 1 个文件被更改,包括 5 次插入5 次删除
  1. 5 5
      libnetwork/drivers/bridge/setup_ip_forwarding.go

+ 5 - 5
libnetwork/drivers/bridge/setup_ip_forwarding.go

@@ -34,11 +34,11 @@ func setupIPForwarding(enableIPTables bool) error {
 		if err := configureIPForwarding(true); err != nil {
 		if err := configureIPForwarding(true); err != nil {
 			return fmt.Errorf("Enabling IP forwarding failed: %v", err)
 			return fmt.Errorf("Enabling IP forwarding failed: %v", err)
 		}
 		}
-		// When enabling ip_forward set the default policy on forward chain to
-		// drop only if the daemon option iptables is not set to false.
-		if !enableIPTables {
-			return nil
-		}
+	}
+
+	// Set the default policy on forward chain to drop only if the
+	// daemon option iptables is not set to false.
+	if enableIPTables {
 		if err := iptables.SetDefaultPolicy(iptables.Filter, "FORWARD", iptables.Drop); err != nil {
 		if err := iptables.SetDefaultPolicy(iptables.Filter, "FORWARD", iptables.Drop); err != nil {
 			if err := configureIPForwarding(false); err != nil {
 			if err := configureIPForwarding(false); err != nil {
 				logrus.Errorf("Disabling IP forwarding failed, %v", err)
 				logrus.Errorf("Disabling IP forwarding failed, %v", err)