Merge pull request #45891 from corhere/fix-daemon-restart-iptables-collision

integration: disable iptables in parallel tests
This commit is contained in:
Sebastiaan van Stijn 2023-07-05 21:48:20 +02:00 committed by GitHub
commit 11c6ec6eb2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 6 deletions

View file

@ -140,7 +140,7 @@ func TestDaemonHostGatewayIP(t *testing.T) {
// Verify the IP in /etc/hosts is same as host-gateway-ip
d := daemon.New(t)
// Verify the IP in /etc/hosts is same as the default bridge's IP
d.StartWithBusybox(t)
d.StartWithBusybox(t, "--iptables=false")
c := d.NewClientT(t)
ctx := context.Background()
cID := container.Run(ctx, t, c,
@ -157,7 +157,7 @@ func TestDaemonHostGatewayIP(t *testing.T) {
d.Stop(t)
// Verify the IP in /etc/hosts is same as host-gateway-ip
d.StartWithBusybox(t, "--host-gateway-ip=6.7.8.9")
d.StartWithBusybox(t, "--iptables=false", "--host-gateway-ip=6.7.8.9")
cID = container.Run(ctx, t, c,
container.WithExtraHost("host.docker.internal:host-gateway"),
)
@ -208,7 +208,7 @@ func TestRestartDaemonWithRestartingContainer(t *testing.T) {
c.HasBeenStartedBefore = true
})
d.Start(t)
d.Start(t, "--iptables=false")
ctxTimeout, cancel := context.WithTimeout(ctx, 30*time.Second)
defer cancel()
@ -256,7 +256,7 @@ func TestHardRestartWhenContainerIsRunning(t *testing.T) {
})
}
d.Start(t)
d.Start(t, "--iptables=false")
t.Run("RestartPolicy=none", func(t *testing.T) {
ctx, cancel := context.WithTimeout(ctx, 5*time.Second)

View file

@ -43,7 +43,7 @@ func TestContainerKillOnDaemonStart(t *testing.T) {
assert.Assert(t, inspect.State.Running)
assert.NilError(t, d.Kill())
d.Start(t)
d.Start(t, "--iptables=false")
inspect, err = client.ContainerInspect(ctx, id)
assert.Check(t, is.Nil(err))

View file

@ -27,7 +27,7 @@ func TestImportExtremelyLargeImageWorks(t *testing.T) {
// Spin up a new daemon, so that we can run this test in parallel (it's a slow test)
d := daemon.New(t)
d.Start(t)
d.Start(t, "--iptables=false")
defer d.Stop(t)
client := d.NewClientT(t)