Ver Fonte

Merge pull request #29459 from yongtang/29365-follow-up

Allow containers to continue even if mount failed after live restore
Sebastiaan van Stijn há 8 anos atrás
pai
commit
110a95717d
1 ficheiros alterados com 7 adições e 2 exclusões
  1. 7 2
      daemon/daemon.go

+ 7 - 2
daemon/daemon.go

@@ -150,8 +150,13 @@ func (daemon *Daemon) restore() error {
 			}
 			container.RWLayer = rwlayer
 			if err := daemon.Mount(container); err != nil {
-				logrus.Errorf("Failed to mount container %v: %v", id, err)
-				continue
+				// The mount is unlikely to fail. However, in case mount fails
+				// the container should be allowed to restore here. Some functionalities
+				// (like docker exec -u user) might be missing but container is able to be
+				// stopped/restarted/removed.
+				// See #29365 for related information.
+				// The error is only logged here.
+				logrus.Warnf("Failed to mount container %v: %v", id, err)
 			}
 			logrus.Debugf("Loaded container %v", container.ID)