0ct0pu5/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

libnetwork/osl: make newKey and newInfo a t.Helper()

Browse source 
Both were passed testing.T, but it was not used, so let's make use of it.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2023-08-02 23:57:40 +02:00
parent d9442aab88
commit 0da721ec38
No known key found for this signature in database
GPG key ID: 76698F39D527CE8C
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
libnetwork/osl/sandbox_linux_test.go
View file

@ -37,6 +37,7 @@ func generateRandomName(prefix string, size int) (string, error) {
}
func newKey(t *testing.T) (string, error) {
t.Helper()
name, err := generateRandomName("netns", 12)
if err != nil {
return "", err
@ -55,7 +56,8 @@ func newKey(t *testing.T) (string, error) {
return name, nil
}
func newInfo(hnd *netlink.Handle, t *testing.T) (Sandbox, error) {
func newInfo(t *testing.T, hnd *netlink.Handle) (Sandbox, error) {
t.Helper()
veth := &netlink.Veth{
LinkAttrs: netlink.LinkAttrs{Name: vethName1, TxQLen: 0},
PeerName: vethName2,
@ -400,7 +402,7 @@ func TestSandboxCreate(t *testing.T) {
t.Fatalf("s.Key() returned %s. Expected %s", s.Key(), key)
}
tbox, err := newInfo(ns.NlHandle(), t)
tbox, err := newInfo(t, ns.NlHandle())
if err != nil {
t.Fatalf("Failed to generate new sandbox info: %v", err)
}
@ -499,7 +501,7 @@ func TestAddRemoveInterface(t *testing.T) {
t.Fatalf("s.Key() returned %s. Expected %s", s.Key(), key)
}
tbox, err := newInfo(ns.NlHandle(), t)
tbox, err := newInfo(t, ns.NlHandle())
if err != nil {
t.Fatalf("Failed to generate new sandbox info: %v", err)
}