Просмотр исходного кода

Fix removing mountpoints on container rm fail

Ensure that the the container's mountpoints are cleaned up if the
container is force removed.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Brian Goff 9 лет назад
Родитель
Сommit
08ca18b59d
1 измененных файлов с 6 добавлено и 7 удалено
  1. 6 7
      daemon/delete.go

+ 6 - 7
daemon/delete.go

@@ -43,15 +43,14 @@ func (daemon *Daemon) ContainerRm(name string, config *types.ContainerRmConfig)
 		return daemon.rmLink(container, name)
 		return daemon.rmLink(container, name)
 	}
 	}
 
 
-	if err := daemon.cleanupContainer(container, config.ForceRemove); err != nil {
-		return err
-	}
-
-	if err := daemon.removeMountPoints(container, config.RemoveVolume); err != nil {
-		logrus.Error(err)
+	err = daemon.cleanupContainer(container, config.ForceRemove)
+	if err == nil || config.ForceRemove {
+		if e := daemon.removeMountPoints(container, config.RemoveVolume); e != nil {
+			logrus.Error(e)
+		}
 	}
 	}
 
 
-	return nil
+	return err
 }
 }
 
 
 func (daemon *Daemon) rmLink(container *container.Container, name string) error {
 func (daemon *Daemon) rmLink(container *container.Container, name string) error {