浏览代码

jsonfilelog_test: check err from open before close

Fix warnings like this one:

> daemon/logger/jsonfilelog/jsonfilelog_test.go:191:3: SA5001: should check returned error before deferring file.Close() (staticcheck)
> 		defer file.Close()
>		^

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Kir Kolyshkin 6 年之前
父节点
当前提交
04129678a6
共有 1 个文件被更改,包括 4 次插入4 次删除
  1. 4 4
      daemon/logger/jsonfilelog/jsonfilelog_test.go

+ 4 - 4
daemon/logger/jsonfilelog/jsonfilelog_test.go

@@ -188,15 +188,15 @@ func TestJSONFileLoggerWithOpts(t *testing.T) {
 		}
 
 		file, err := os.Open(filename + ".1.gz")
-		defer file.Close()
 		if err != nil {
 			t.Fatal(err)
 		}
+		defer file.Close()
 		zipReader, err := gzip.NewReader(file)
-		defer zipReader.Close()
 		if err != nil {
 			t.Fatal(err)
 		}
+		defer zipReader.Close()
 		penUlt, err = ioutil.ReadAll(zipReader)
 		if err != nil {
 			t.Fatal(err)
@@ -204,15 +204,15 @@ func TestJSONFileLoggerWithOpts(t *testing.T) {
 	}
 
 	file, err := os.Open(filename + ".2.gz")
-	defer file.Close()
 	if err != nil {
 		t.Fatal(err)
 	}
+	defer file.Close()
 	zipReader, err := gzip.NewReader(file)
-	defer zipReader.Close()
 	if err != nil {
 		t.Fatal(err)
 	}
+	defer zipReader.Close()
 	antepenult, err := ioutil.ReadAll(zipReader)
 	if err != nil {
 		t.Fatal(err)