Bläddra i källkod

Follow up to PR 38407

This fix is a follow up to PR 38407 to use assert.Error
and assert.NilError when appropriate

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Yong Tang 6 år sedan
förälder
incheckning
0281db99a9
1 ändrade filer med 4 tillägg och 6 borttagningar
  1. 4 6
      daemon/logger/awslogs/cloudwatchlogs_test.go

+ 4 - 6
daemon/logger/awslogs/cloudwatchlogs_test.go

@@ -1498,10 +1498,9 @@ func TestValidateLogOptionsForceFlushIntervalSeconds(t *testing.T) {
 			err := ValidateLogOpt(cfg)
 			err := ValidateLogOpt(cfg)
 			if tc.shouldErr {
 			if tc.shouldErr {
 				expectedErr := "must specify a positive integer for log opt 'awslogs-force-flush-interval-seconds': " + tc.input
 				expectedErr := "must specify a positive integer for log opt 'awslogs-force-flush-interval-seconds': " + tc.input
-				assert.Check(t, err != nil, "Expected an error")
-				assert.Check(t, is.Equal(err.Error(), expectedErr), "Received invalid error")
+				assert.Error(t, err, expectedErr)
 			} else {
 			} else {
-				assert.Check(t, err == nil, "Unexpected error")
+				assert.NilError(t, err)
 			}
 			}
 		})
 		})
 	}
 	}
@@ -1528,10 +1527,9 @@ func TestValidateLogOptionsMaxBufferedEvents(t *testing.T) {
 			err := ValidateLogOpt(cfg)
 			err := ValidateLogOpt(cfg)
 			if tc.shouldErr {
 			if tc.shouldErr {
 				expectedErr := "must specify a positive integer for log opt 'awslogs-max-buffered-events': " + tc.input
 				expectedErr := "must specify a positive integer for log opt 'awslogs-max-buffered-events': " + tc.input
-				assert.Check(t, err != nil, "Expected an error")
-				assert.Check(t, is.Equal(err.Error(), expectedErr), "Received invalid error")
+				assert.Error(t, err, expectedErr)
 			} else {
 			} else {
-				assert.Check(t, err == nil, "Unexpected error")
+				assert.NilError(t, err)
 			}
 			}
 		})
 		})
 	}
 	}