diff --git a/daemon/container_operations.go b/daemon/container_operations.go index 8bda41f14d..ac366c08d2 100644 --- a/daemon/container_operations.go +++ b/daemon/container_operations.go @@ -679,7 +679,7 @@ func buildEndpointDNSNames(ctr *container.Container, aliases []string) []string return sliceutil.Dedup(dnsNames) } -func (daemon *Daemon) connectToNetwork(cfg *config.Config, container *container.Container, idOrName string, endpointConfig *networktypes.EndpointSettings, updateSettings bool) (err error) { +func (daemon *Daemon) connectToNetwork(cfg *config.Config, container *container.Container, idOrName string, endpointConfig *networktypes.EndpointSettings, updateSettings bool) (retErr error) { start := time.Now() if container.HostConfig.NetworkMode.IsContainer() { return runconfig.ErrConflictSharedNetwork @@ -737,8 +737,8 @@ func (daemon *Daemon) connectToNetwork(cfg *config.Config, container *container. return err } defer func() { - if err != nil { - if e := ep.Delete(false); e != nil { + if retErr != nil { + if err := ep.Delete(false); err != nil { log.G(context.TODO()).Warnf("Could not rollback container connection to network %s", idOrName) } }