123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109 |
- From e2a9a34af4fd99de652638bfc0365aba284b95f8 Mon Sep 17 00:00:00 2001
- From: Ben Hutchings <ben@decadent.org.uk>
- Date: Fri, 22 Jun 2018 17:27:00 +0100
- Subject: [PATCH 2/2] android: Enable building ashmem and binder as modules
- We want to enable use of the Android ashmem and binder drivers to
- support Anbox, but they should not be built-in as that would waste
- resources and increase security attack surface on systems that don't
- need them.
- - Add a MODULE_LICENSE declaration to ashmem
- - Change the Makefiles to build each driver as an object with the
- "_linux" suffix (which is what Anbox expects)
- - Change config symbol types to tristate
- ---
- drivers/android/Kconfig | 2 +-
- drivers/android/Makefile | 7 ++++---
- drivers/android/binder_alloc.c | 2 +-
- drivers/staging/android/Kconfig | 2 +-
- drivers/staging/android/Makefile | 3 ++-
- drivers/staging/android/ashmem.c | 3 +++
- 6 files changed, 12 insertions(+), 7 deletions(-)
- diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig
- index 53b22e26266c..f3c50236e8d1 100644
- --- a/drivers/android/Kconfig
- +++ b/drivers/android/Kconfig
- @@ -9,7 +9,7 @@ config ANDROID
- if ANDROID
-
- config ANDROID_BINDER_IPC
- - bool "Android Binder IPC Driver"
- + tristate "Android Binder IPC Driver"
- depends on MMU
- default n
- help
- diff --git a/drivers/android/Makefile b/drivers/android/Makefile
- index c9d3d0c99c25..55411d9a9c2a 100644
- --- a/drivers/android/Makefile
- +++ b/drivers/android/Makefile
- @@ -1,6 +1,7 @@
- # SPDX-License-Identifier: GPL-2.0-only
- ccflags-y += -I$(src) # needed for trace events
-
- -obj-$(CONFIG_ANDROID_BINDERFS) += binderfs.o
- -obj-$(CONFIG_ANDROID_BINDER_IPC) += binder.o binder_alloc.o
- -obj-$(CONFIG_ANDROID_BINDER_IPC_SELFTEST) += binder_alloc_selftest.o
- +obj-$(CONFIG_ANDROID_BINDER_IPC) += binder_linux.o
- +binder_linux-y := binder.o binder_alloc.o
- +binder_linux-$(CONFIG_ANDROID_BINDERFS) += binderfs.o
- +binder_linux-$(CONFIG_ANDROID_BINDER_IPC_SELFTEST) += binder_alloc_selftest.o
- diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c
- index 7caf74ad2405..9202a44bd55d 100644
- --- a/drivers/android/binder_alloc.c
- +++ b/drivers/android/binder_alloc.c
- @@ -38,7 +38,7 @@ enum {
- };
- static uint32_t binder_alloc_debug_mask = BINDER_DEBUG_USER_ERROR;
-
- -module_param_named(debug_mask, binder_alloc_debug_mask,
- +module_param_named(alloc_debug_mask, binder_alloc_debug_mask,
- uint, 0644);
-
- #define binder_alloc_debug(mask, x...) \
- diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
- index 70498adb1575..5c35653ed36d 100644
- --- a/drivers/staging/android/Kconfig
- +++ b/drivers/staging/android/Kconfig
- @@ -4,7 +4,7 @@ menu "Android"
- if ANDROID
-
- config ASHMEM
- - bool "Enable the Anonymous Shared Memory Subsystem"
- + tristate "Enable the Anonymous Shared Memory Subsystem"
- depends on SHMEM
- help
- The ashmem subsystem is a new shared memory allocator, similar to
- diff --git a/drivers/staging/android/Makefile b/drivers/staging/android/Makefile
- index e9a55a5e6529..60cb8eacc793 100644
- --- a/drivers/staging/android/Makefile
- +++ b/drivers/staging/android/Makefile
- @@ -1,4 +1,5 @@
- # SPDX-License-Identifier: GPL-2.0
- ccflags-y += -I$(src) # needed for trace events
-
- -obj-$(CONFIG_ASHMEM) += ashmem.o
- +obj-$(CONFIG_ASHMEM) += ashmem_linux.o
- +ashmem_linux-y += ashmem.o
- diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
- index 4789d36ddfd3..f86efd3da373 100644
- --- a/drivers/staging/android/ashmem.c
- +++ b/drivers/staging/android/ashmem.c
- @@ -24,6 +24,7 @@
- #include <linux/bitops.h>
- #include <linux/mutex.h>
- #include <linux/shmem_fs.h>
- +#include <linux/module.h>
- #include "ashmem.h"
-
- #define ASHMEM_NAME_PREFIX "dev/ashmem/"
- @@ -965,3 +966,5 @@ static int __init ashmem_init(void)
- return ret;
- }
- device_initcall(ashmem_init);
- +
- +MODULE_LICENSE("GPL v2");
- --
- 2.30.1
|