08d60d7521
This also fixes a bug where task IDs were being deallocated from the wrong IDAllocator. I don't know if it was actually possible to cause any real trouble with that mistake, nor do I know how to write a test for it, but this makes the bug go away.
38 lines
1.5 KiB
C++
38 lines
1.5 KiB
C++
/*
|
|
* Copyright (c) 2022, Linus Groh <linusg@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibWeb/Fetch/Infrastructure/FetchController.h>
|
|
#include <LibWeb/Fetch/Infrastructure/Task.h>
|
|
#include <LibWeb/HTML/EventLoop/EventLoop.h>
|
|
|
|
namespace Web::Fetch::Infrastructure {
|
|
|
|
// https://fetch.spec.whatwg.org/#queue-a-fetch-task
|
|
HTML::TaskID queue_fetch_task(JS::Object& task_destination, JS::NonnullGCPtr<JS::HeapFunction<void()>> algorithm)
|
|
{
|
|
// FIXME: 1. If taskDestination is a parallel queue, then enqueue algorithm to taskDestination.
|
|
|
|
// 2. Otherwise, queue a global task on the networking task source with taskDestination and algorithm.
|
|
return HTML::queue_global_task(HTML::Task::Source::Networking, task_destination, algorithm);
|
|
}
|
|
|
|
// AD-HOC: This overload allows tracking the queued task within the fetch controller so that we may cancel queued tasks
|
|
// when the spec indicates that we must stop an ongoing fetch.
|
|
HTML::TaskID queue_fetch_task(JS::NonnullGCPtr<FetchController> fetch_controller, JS::Object& task_destination, JS::NonnullGCPtr<JS::HeapFunction<void()>> algorithm)
|
|
{
|
|
auto fetch_task_id = fetch_controller->next_fetch_task_id();
|
|
|
|
auto& heap = task_destination.heap();
|
|
auto html_task_id = queue_fetch_task(task_destination, JS::create_heap_function(heap, [fetch_controller, fetch_task_id, algorithm]() {
|
|
fetch_controller->fetch_task_complete(fetch_task_id);
|
|
algorithm->function()();
|
|
}));
|
|
|
|
fetch_controller->fetch_task_queued(fetch_task_id, html_task_id);
|
|
return html_task_id;
|
|
}
|
|
|
|
}
|