ladybird/Userland/Libraries/LibWeb/HTML/WorkerLocation.h
Shannon Booth cc55732332 LibURL+Everywhere: Only percent decode URL paths when actually needed
Web specs do not return through javascript percent decoded URL path
components - but we were doing this in a number of places due to the
default behaviour of URL::serialize_path.

Since percent encoded URL paths may not contain valid UTF-8 - this was
resulting in us crashing in these places.

For example - on an HTMLAnchorElement when retrieving the pathname for
the URL of:

http://ladybird.org/foo%C2%91%91

To fix this make the URL class only return the percent encoded
serialized path, matching the URL spec. When the decoded path is
required instead explicitly call URL::percent_decode.

This fixes a crash running WPT URL tests for the anchor element on:

https://wpt.live/url/a-element.html
2024-08-05 09:58:13 +02:00

40 lines
1.1 KiB
C++

/*
* Copyright (c) 2022, Andrew Kaster <akaster@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <LibWeb/Bindings/PlatformObject.h>
namespace Web::HTML {
// https://html.spec.whatwg.org/multipage/workers.html#worker-locations
class WorkerLocation : public Bindings::PlatformObject {
WEB_PLATFORM_OBJECT(WorkerLocation, Bindings::PlatformObject);
JS_DECLARE_ALLOCATOR(WorkerLocation);
public:
virtual ~WorkerLocation() override;
WebIDL::ExceptionOr<String> href() const;
WebIDL::ExceptionOr<String> origin() const;
WebIDL::ExceptionOr<String> protocol() const;
WebIDL::ExceptionOr<String> host() const;
WebIDL::ExceptionOr<String> hostname() const;
WebIDL::ExceptionOr<String> port() const;
String pathname() const;
WebIDL::ExceptionOr<String> search() const;
WebIDL::ExceptionOr<String> hash() const;
private:
explicit WorkerLocation(WorkerGlobalScope&);
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
JS::NonnullGCPtr<WorkerGlobalScope> m_global_scope;
};
}