821702fadd
This makes YouTube's thumbnails start appearing on the homepage.
Yes,seriously.
Simply put, this is because this check failed when Comment had the
incorrect prototype:
90cb97f847/packages/shadycss/src/style-util.js (L397)
This causes it to try and reconvert style sheets that are already in
Shady format, which would cause it to spuriously add things such as
class selectors on the end of tag selectors. This caused nothing to
match the selectors.
When YouTube is generating the thumbnails, it checks if the thumbnail
grid container has a non-zero clientWidth. If it's zero, it simply
bails generating thumbnails. Since the selectors for this container did
not apply, we would not properly create a paint box for it, causing
clientWidth to return zero.
34 lines
1,003 B
C++
34 lines
1,003 B
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibWeb/Bindings/CommentPrototype.h>
|
|
#include <LibWeb/DOM/Comment.h>
|
|
#include <LibWeb/HTML/Window.h>
|
|
#include <LibWeb/Layout/TextNode.h>
|
|
|
|
namespace Web::DOM {
|
|
|
|
Comment::Comment(Document& document, DeprecatedString const& data)
|
|
: CharacterData(document, NodeType::COMMENT_NODE, data)
|
|
{
|
|
}
|
|
|
|
// https://dom.spec.whatwg.org/#dom-comment-comment
|
|
WebIDL::ExceptionOr<JS::NonnullGCPtr<Comment>> Comment::construct_impl(JS::Realm& realm, DeprecatedString const& data)
|
|
{
|
|
auto& window = verify_cast<HTML::Window>(realm.global_object());
|
|
return MUST_OR_THROW_OOM(realm.heap().allocate<Comment>(realm, window.associated_document(), data));
|
|
}
|
|
|
|
JS::ThrowCompletionOr<void> Comment::initialize(JS::Realm& realm)
|
|
{
|
|
MUST_OR_THROW_OOM(Base::initialize(realm));
|
|
set_prototype(&Bindings::ensure_web_prototype<Bindings::CommentPrototype>(realm, "Comment"));
|
|
|
|
return {};
|
|
}
|
|
|
|
}
|