34591ff3d9
As it turns out, making everyone piggyback on HTML::ImageRequest had some major flaws, as HTMLImageElement may decide to abort an ongoing fetch or wipe out image data, even when someone else is using the same image request. To avoid this issue, this patch introduces SharedImageRequest, and then implements ImageRequest on top of that. Other clients of the ImageRequest API are moved to SharedImageRequest as well, and ImageRequest is now only used by HTMLImageElement. This fixes an issue with image data disappearing and leading to asserts and/or visually absent images.
86 lines
2.8 KiB
C++
86 lines
2.8 KiB
C++
/*
|
|
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibCore/Forward.h>
|
|
#include <LibGfx/Forward.h>
|
|
#include <LibWeb/HTML/FormAssociatedElement.h>
|
|
#include <LibWeb/HTML/HTMLElement.h>
|
|
#include <LibWeb/HTML/NavigableContainer.h>
|
|
#include <LibWeb/Layout/ImageProvider.h>
|
|
#include <LibWeb/Loader/Resource.h>
|
|
|
|
namespace Web::HTML {
|
|
|
|
class HTMLObjectElement final
|
|
: public NavigableContainer
|
|
, public FormAssociatedElement
|
|
, public ResourceClient
|
|
, public Layout::ImageProvider {
|
|
WEB_PLATFORM_OBJECT(HTMLObjectElement, NavigableContainer)
|
|
FORM_ASSOCIATED_ELEMENT(NavigableContainer, HTMLObjectElement)
|
|
|
|
enum class Representation {
|
|
Unknown,
|
|
Image,
|
|
NestedBrowsingContext,
|
|
Children,
|
|
};
|
|
|
|
public:
|
|
virtual ~HTMLObjectElement() override;
|
|
|
|
virtual void parse_attribute(DeprecatedFlyString const& name, DeprecatedString const& value) override;
|
|
|
|
DeprecatedString data() const;
|
|
void set_data(DeprecatedString const& data) { MUST(set_attribute(HTML::AttributeNames::data, data)); }
|
|
|
|
DeprecatedString type() const { return attribute(HTML::AttributeNames::type); }
|
|
|
|
// ^FormAssociatedElement
|
|
// https://html.spec.whatwg.org/multipage/forms.html#category-listed
|
|
virtual bool is_listed() const override { return true; }
|
|
|
|
private:
|
|
HTMLObjectElement(DOM::Document&, DOM::QualifiedName);
|
|
|
|
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
|
|
|
|
virtual JS::GCPtr<Layout::Node> create_layout_node(NonnullRefPtr<CSS::StyleProperties>) override;
|
|
|
|
bool has_ancestor_media_element_or_object_element_not_showing_fallback_content() const;
|
|
|
|
void queue_element_task_to_run_object_representation_steps();
|
|
void run_object_representation_handler_steps(Optional<DeprecatedString> resource_type);
|
|
void run_object_representation_completed_steps(Representation);
|
|
void run_object_representation_fallback_steps();
|
|
|
|
void load_image();
|
|
void update_layout_and_child_objects(Representation);
|
|
|
|
// ^ResourceClient
|
|
virtual void resource_did_load() override;
|
|
virtual void resource_did_fail() override;
|
|
|
|
// ^DOM::Element
|
|
virtual i32 default_tab_index_value() const override;
|
|
|
|
// ^Layout::ImageProvider
|
|
virtual Optional<CSSPixels> intrinsic_width() const override;
|
|
virtual Optional<CSSPixels> intrinsic_height() const override;
|
|
virtual Optional<float> intrinsic_aspect_ratio() const override;
|
|
virtual RefPtr<Gfx::Bitmap const> current_image_bitmap(Gfx::IntSize = {}) const override;
|
|
virtual void set_visible_in_viewport(bool) override;
|
|
|
|
Representation m_representation { Representation::Unknown };
|
|
|
|
RefPtr<DecodedImageData const> image_data() const;
|
|
|
|
RefPtr<SharedImageRequest> m_image_request;
|
|
};
|
|
|
|
}
|