5285e22f2a
The main intention of this change is to have a consistent look and behavior across all scrollbars, including elements with `overflow: scroll` and `overflow: auto`, iframes, and a page. Before: - Page's scrollbar is painted by Browser (Qt/AppKit) using the corresponding UI framework style, - Both WebContent and Browser know the scroll position offset. - WebContent uses did_request_scroll_to() IPC call to send updates. - Browser uses set_viewport_rect() to send updates. After: - Page's scrollbar is painted on WebContent side using the same style as currently used for elements with `overflow: scroll` and `overflow: auto`. A nice side effects: scrollbars are now painted for iframes, and page's scrollbar respects scrollbar-width CSS property. - Only WebContent knows scroll position offset. - did_request_scroll_to() is no longer used. - set_viewport_rect() is changed to set_viewport_size().
43 lines
1.2 KiB
C++
43 lines
1.2 KiB
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibWeb/DOM/Document.h>
|
|
#include <LibWeb/Layout/FrameBox.h>
|
|
#include <LibWeb/Layout/Viewport.h>
|
|
#include <LibWeb/Painting/NestedBrowsingContextPaintable.h>
|
|
|
|
namespace Web::Layout {
|
|
|
|
JS_DEFINE_ALLOCATOR(FrameBox);
|
|
|
|
FrameBox::FrameBox(DOM::Document& document, DOM::Element& element, NonnullRefPtr<CSS::StyleProperties> style)
|
|
: ReplacedBox(document, element, move(style))
|
|
{
|
|
}
|
|
|
|
FrameBox::~FrameBox() = default;
|
|
|
|
void FrameBox::prepare_for_replaced_layout()
|
|
{
|
|
// FIXME: Do proper error checking, etc.
|
|
set_natural_width(dom_node().get_attribute_value(HTML::AttributeNames::width).to_number<int>().value_or(300));
|
|
set_natural_height(dom_node().get_attribute_value(HTML::AttributeNames::height).to_number<int>().value_or(150));
|
|
}
|
|
|
|
void FrameBox::did_set_content_size()
|
|
{
|
|
ReplacedBox::did_set_content_size();
|
|
|
|
if (dom_node().content_navigable())
|
|
dom_node().content_navigable()->set_viewport_size(paintable_box()->content_size());
|
|
}
|
|
|
|
JS::GCPtr<Painting::Paintable> FrameBox::create_paintable() const
|
|
{
|
|
return Painting::NestedBrowsingContextPaintable::create(*this);
|
|
}
|
|
|
|
}
|