
This replaces the FlyStrings for ARIA roles that were constructed in a [[gnu::constructor]] with a single enum. I came across this as the DOM inspector was crashing due to a null FlyString for an ARIA role. After fixing that, I was confused as to why these roles were not an enum. Looking at the spec there's a fixed list of roles and switching from references to static strings to an enum was pretty much an exercise in find and replace :). No functional changes (outside of fixing the mentioned crash).
39 lines
1.1 KiB
C++
39 lines
1.1 KiB
C++
/*
|
|
* Copyright (c) 2020, the SerenityOS developers.
|
|
* Copyright (c) 2022, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibWeb/DOM/ARIARoles.h>
|
|
#include <LibWeb/HTML/HTMLElement.h>
|
|
|
|
namespace Web::HTML {
|
|
|
|
class HTMLTableSectionElement final : public HTMLElement {
|
|
WEB_PLATFORM_OBJECT(HTMLTableSectionElement, HTMLElement);
|
|
|
|
public:
|
|
virtual ~HTMLTableSectionElement() override;
|
|
|
|
JS::NonnullGCPtr<DOM::HTMLCollection> rows() const;
|
|
WebIDL::ExceptionOr<JS::NonnullGCPtr<HTMLTableRowElement>> insert_row(long index);
|
|
WebIDL::ExceptionOr<void> delete_row(long index);
|
|
|
|
// https://www.w3.org/TR/html-aria/#el-tbody
|
|
// https://www.w3.org/TR/html-aria/#el-tfoot
|
|
// https://www.w3.org/TR/html-aria/#el-thead
|
|
virtual Optional<DOM::ARIARoles::Role> default_role() const override { return DOM::ARIARoles::Role::rowgroup; }
|
|
|
|
private:
|
|
HTMLTableSectionElement(DOM::Document&, DOM::QualifiedName);
|
|
|
|
virtual void initialize(JS::Realm&) override;
|
|
virtual void visit_edges(Cell::Visitor&) override;
|
|
|
|
JS::GCPtr<DOM::HTMLCollection> mutable m_rows;
|
|
};
|
|
|
|
}
|