
Before this we used an ad-hoc combination of references and 'variables' stored in a hashmap. This worked in most cases but is not spec like. Additionally hoisting, dynamically naming functions and scope analysis was not done properly. This patch fixes all of that by: - Implement BindingInitialization for destructuring assignment. - Implementing a new ScopePusher which tracks the lexical and var scoped declarations. This hoists functions to the top level if no lexical declaration name overlaps. Furthermore we do checking of redeclarations in the ScopePusher now requiring less checks all over the place. - Add methods for parsing the directives and statement lists instead of having that code duplicated in multiple places. This allows declarations to pushed to the appropriate scope more easily. - Remove the non spec way of storing 'variables' in DeclarativeEnvironment and make Reference follow the spec instead of checking both the bindings and 'variables'. - Remove all scoping related things from the Interpreter. And instead use environments as specified by the spec. This also includes fixing that NativeFunctions did not produce a valid FunctionEnvironment which could cause issues with callbacks and eval. All FunctionObjects now have a valid NewFunctionEnvironment implementation. - Remove execute_statements from Interpreter and instead use ASTNode::execute everywhere this simplifies AST.cpp as you no longer need to worry about which method to call. - Make ScopeNodes setup their own environment. This uses four different methods specified by the spec {Block, Function, Eval, Global}DeclarationInstantiation with the annexB extensions. - Implement and use NamedEvaluation where specified. Additionally there are fixes to things exposed by these changes to eval, {for, for-in, for-of} loops and assignment. Finally it also fixes some tests in test-js which where passing before but not now that we have correct behavior :^).
210 lines
8.3 KiB
C++
210 lines
8.3 KiB
C++
/*
|
|
* Copyright (c) 2020-2021, Andreas Kling <kling@serenityos.org>
|
|
* Copyright (c) 2021, Linus Groh <linusg@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibJS/AST.h>
|
|
#include <LibJS/Runtime/DeclarativeEnvironment.h>
|
|
#include <LibJS/Runtime/GlobalEnvironment.h>
|
|
#include <LibJS/Runtime/GlobalObject.h>
|
|
#include <LibJS/Runtime/ObjectEnvironment.h>
|
|
|
|
namespace JS {
|
|
|
|
// 9.1.2.5 NewGlobalEnvironment ( G, thisValue ), https://tc39.es/ecma262/#sec-newglobalenvironment
|
|
GlobalEnvironment::GlobalEnvironment(GlobalObject& global_object, Object& this_value)
|
|
: Environment(nullptr)
|
|
, m_global_this_value(&this_value)
|
|
{
|
|
m_object_record = global_object.heap().allocate<ObjectEnvironment>(global_object, global_object, ObjectEnvironment::IsWithEnvironment::No, nullptr);
|
|
m_declarative_record = global_object.heap().allocate<DeclarativeEnvironment>(global_object);
|
|
}
|
|
|
|
void GlobalEnvironment::visit_edges(Cell::Visitor& visitor)
|
|
{
|
|
Base::visit_edges(visitor);
|
|
visitor.visit(m_object_record);
|
|
visitor.visit(m_global_this_value);
|
|
visitor.visit(m_declarative_record);
|
|
}
|
|
|
|
Value GlobalEnvironment::get_this_binding(GlobalObject&) const
|
|
{
|
|
return m_global_this_value;
|
|
}
|
|
|
|
// 9.1.1.4.1 HasBinding ( N ), https://tc39.es/ecma262/#sec-global-environment-records-hasbinding-n
|
|
bool GlobalEnvironment::has_binding(FlyString const& name) const
|
|
{
|
|
if (m_declarative_record->has_binding(name))
|
|
return true;
|
|
return m_object_record->has_binding(name);
|
|
}
|
|
|
|
// 9.1.1.4.2 CreateMutableBinding ( N, D ), https://tc39.es/ecma262/#sec-global-environment-records-createmutablebinding-n-d
|
|
void GlobalEnvironment::create_mutable_binding(GlobalObject& global_object, FlyString const& name, bool can_be_deleted)
|
|
{
|
|
if (m_declarative_record->has_binding(name)) {
|
|
global_object.vm().throw_exception<TypeError>(global_object, ErrorType::FixmeAddAnErrorString);
|
|
return;
|
|
}
|
|
m_declarative_record->create_mutable_binding(global_object, name, can_be_deleted);
|
|
}
|
|
|
|
// 9.1.1.4.3 CreateImmutableBinding ( N, S ), https://tc39.es/ecma262/#sec-global-environment-records-createimmutablebinding-n-s
|
|
void GlobalEnvironment::create_immutable_binding(GlobalObject& global_object, FlyString const& name, bool strict)
|
|
{
|
|
if (m_declarative_record->has_binding(name)) {
|
|
global_object.vm().throw_exception<TypeError>(global_object, ErrorType::FixmeAddAnErrorString);
|
|
return;
|
|
}
|
|
m_declarative_record->create_immutable_binding(global_object, name, strict);
|
|
}
|
|
|
|
// 9.1.1.4.4 InitializeBinding ( N, V ), https://tc39.es/ecma262/#sec-global-environment-records-initializebinding-n-v
|
|
void GlobalEnvironment::initialize_binding(GlobalObject& global_object, FlyString const& name, Value value)
|
|
{
|
|
if (m_declarative_record->has_binding(name)) {
|
|
m_declarative_record->initialize_binding(global_object, name, value);
|
|
return;
|
|
}
|
|
m_object_record->initialize_binding(global_object, name, value);
|
|
}
|
|
|
|
// 9.1.1.4.5 SetMutableBinding ( N, V, S ), https://tc39.es/ecma262/#sec-global-environment-records-setmutablebinding-n-v-s
|
|
void GlobalEnvironment::set_mutable_binding(GlobalObject& global_object, FlyString const& name, Value value, bool strict)
|
|
{
|
|
if (m_declarative_record->has_binding(name)) {
|
|
m_declarative_record->set_mutable_binding(global_object, name, value, strict);
|
|
return;
|
|
}
|
|
|
|
m_object_record->set_mutable_binding(global_object, name, value, strict);
|
|
}
|
|
|
|
// 9.1.1.4.6 GetBindingValue ( N, S ), https://tc39.es/ecma262/#sec-global-environment-records-getbindingvalue-n-s
|
|
Value GlobalEnvironment::get_binding_value(GlobalObject& global_object, FlyString const& name, bool strict)
|
|
{
|
|
if (m_declarative_record->has_binding(name))
|
|
return m_declarative_record->get_binding_value(global_object, name, strict);
|
|
return m_object_record->get_binding_value(global_object, name, strict);
|
|
}
|
|
|
|
// 9.1.1.4.7 DeleteBinding ( N ), https://tc39.es/ecma262/#sec-global-environment-records-deletebinding-n
|
|
bool GlobalEnvironment::delete_binding(GlobalObject& global_object, FlyString const& name)
|
|
{
|
|
if (m_declarative_record->has_binding(name))
|
|
return m_declarative_record->delete_binding(global_object, name);
|
|
|
|
bool existing_prop = m_object_record->binding_object().has_own_property(name);
|
|
if (existing_prop) {
|
|
bool status = m_object_record->delete_binding(global_object, name);
|
|
if (status) {
|
|
m_var_names.remove_all_matching([&](auto& entry) { return entry == name; });
|
|
}
|
|
return status;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
// 9.1.1.4.12 HasVarDeclaration ( N ), https://tc39.es/ecma262/#sec-hasvardeclaration
|
|
bool GlobalEnvironment::has_var_declaration(FlyString const& name) const
|
|
{
|
|
return m_var_names.contains_slow(name);
|
|
}
|
|
|
|
// 9.1.1.4.13 HasLexicalDeclaration ( N ), https://tc39.es/ecma262/#sec-haslexicaldeclaration
|
|
bool GlobalEnvironment::has_lexical_declaration(FlyString const& name) const
|
|
{
|
|
return m_declarative_record->has_binding(name);
|
|
}
|
|
|
|
// 9.1.1.4.14 HasRestrictedGlobalProperty ( N ), https://tc39.es/ecma262/#sec-hasrestrictedglobalproperty
|
|
bool GlobalEnvironment::has_restricted_global_property(FlyString const& name) const
|
|
{
|
|
auto& global_object = m_object_record->binding_object();
|
|
auto existing_prop = TRY_OR_DISCARD(global_object.internal_get_own_property(name));
|
|
if (!existing_prop.has_value())
|
|
return false;
|
|
if (*existing_prop->configurable)
|
|
return false;
|
|
return true;
|
|
}
|
|
|
|
// 9.1.1.4.15 CanDeclareGlobalVar ( N ), https://tc39.es/ecma262/#sec-candeclareglobalvar
|
|
bool GlobalEnvironment::can_declare_global_var(FlyString const& name) const
|
|
{
|
|
auto& vm = this->vm();
|
|
auto& global_object = m_object_record->binding_object();
|
|
bool has_property = global_object.has_own_property(name);
|
|
if (vm.exception())
|
|
return {};
|
|
if (has_property)
|
|
return true;
|
|
return global_object.is_extensible();
|
|
}
|
|
|
|
// 9.1.1.4.16 CanDeclareGlobalFunction ( N ), https://tc39.es/ecma262/#sec-candeclareglobalfunction
|
|
bool GlobalEnvironment::can_declare_global_function(FlyString const& name) const
|
|
{
|
|
auto& global_object = m_object_record->binding_object();
|
|
auto existing_prop = TRY_OR_DISCARD(global_object.internal_get_own_property(name));
|
|
if (!existing_prop.has_value())
|
|
return global_object.is_extensible();
|
|
if (*existing_prop->configurable)
|
|
return true;
|
|
if (existing_prop->is_data_descriptor() && *existing_prop->writable && *existing_prop->enumerable)
|
|
return true;
|
|
return false;
|
|
}
|
|
|
|
// 9.1.1.4.17 CreateGlobalVarBinding ( N, D ), https://tc39.es/ecma262/#sec-createglobalvarbinding
|
|
void GlobalEnvironment::create_global_var_binding(FlyString const& name, bool can_be_deleted)
|
|
{
|
|
auto& vm = this->vm();
|
|
auto& global_object = m_object_record->binding_object();
|
|
bool has_property = global_object.has_own_property(name);
|
|
if (vm.exception())
|
|
return;
|
|
bool extensible = global_object.is_extensible();
|
|
if (vm.exception())
|
|
return;
|
|
if (!has_property && extensible) {
|
|
m_object_record->create_mutable_binding(m_object_record->global_object(), name, can_be_deleted);
|
|
if (vm.exception())
|
|
return;
|
|
m_object_record->initialize_binding(m_object_record->global_object(), name, js_undefined());
|
|
if (vm.exception())
|
|
return;
|
|
}
|
|
if (!m_var_names.contains_slow(name))
|
|
m_var_names.append(name);
|
|
}
|
|
|
|
// 9.1.1.4.18 CreateGlobalFunctionBinding ( N, V, D ), https://tc39.es/ecma262/#sec-createglobalfunctionbinding
|
|
void GlobalEnvironment::create_global_function_binding(FlyString const& name, Value value, bool can_be_deleted)
|
|
{
|
|
auto& vm = this->vm();
|
|
auto& global_object = m_object_record->binding_object();
|
|
auto existing_prop_or_error = global_object.internal_get_own_property(name);
|
|
if (existing_prop_or_error.is_error())
|
|
return;
|
|
auto existing_prop = existing_prop_or_error.release_value();
|
|
PropertyDescriptor desc;
|
|
if (!existing_prop.has_value() || *existing_prop->configurable)
|
|
desc = { .value = value, .writable = true, .enumerable = true, .configurable = can_be_deleted };
|
|
else
|
|
desc = { .value = value };
|
|
global_object.define_property_or_throw(name, desc);
|
|
if (vm.exception())
|
|
return;
|
|
global_object.set(name, value, Object::ShouldThrowExceptions::Yes);
|
|
if (vm.exception())
|
|
return;
|
|
if (!m_var_names.contains_slow(name))
|
|
m_var_names.append(name);
|
|
}
|
|
|
|
}
|