7327a28ccc
As mentioned on Discord earlier, we'll add these to all new functions going forward - this is the backfill. Reasons: - It makes you look at the spec, implementing based on MDN or V8 behavior is a no-go - It makes finding the various functions that are non-compliant easier, in the future everything should either have such a comment or, if it's not from the spec at all, a comment explaining why that is the case - It makes it easier to check whether a certain abstract operation is implemented in LibJS, not all of them use the same name as the spec. E.g. RejectPromise() is Promise::reject() - It makes it easier to reason about vm.arguments(), e.g. when the function has a rest parameter - It makes it easier to see whether a certain function is from a proposal or Annex B Also: - Add arguments to all functions and abstract operations that already had a comment - Fix some outdated section numbers - Replace some ecma-international.org URLs with tc39.es
85 lines
2.5 KiB
C++
85 lines
2.5 KiB
C++
/*
|
|
* Copyright (c) 2020, Matthew Olsson <mattco@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibJS/Runtime/Error.h>
|
|
#include <LibJS/Runtime/GlobalObject.h>
|
|
#include <LibJS/Runtime/SymbolConstructor.h>
|
|
|
|
namespace JS {
|
|
|
|
SymbolConstructor::SymbolConstructor(GlobalObject& global_object)
|
|
: NativeFunction(vm().names.Symbol, *global_object.function_prototype())
|
|
{
|
|
}
|
|
|
|
void SymbolConstructor::initialize(GlobalObject& global_object)
|
|
{
|
|
auto& vm = this->vm();
|
|
NativeFunction::initialize(global_object);
|
|
|
|
// 20.4.2.9 Symbol.prototype, https://tc39.es/ecma262/#sec-symbol.prototype
|
|
define_property(vm.names.prototype, global_object.symbol_prototype(), 0);
|
|
|
|
define_property(vm.names.length, Value(0), Attribute::Configurable);
|
|
|
|
define_native_function(vm.names.for_, for_, 1, Attribute::Writable | Attribute::Configurable);
|
|
define_native_function(vm.names.keyFor, key_for, 1, Attribute::Writable | Attribute::Configurable);
|
|
|
|
#define __JS_ENUMERATE(SymbolName, snake_name) \
|
|
define_property(vm.names.SymbolName, vm.well_known_symbol_##snake_name(), 0);
|
|
JS_ENUMERATE_WELL_KNOWN_SYMBOLS
|
|
#undef __JS_ENUMERATE
|
|
}
|
|
|
|
SymbolConstructor::~SymbolConstructor()
|
|
{
|
|
}
|
|
|
|
// 20.4.1.1 Symbol ( [ description ] ), https://tc39.es/ecma262/#sec-symbol-description
|
|
Value SymbolConstructor::call()
|
|
{
|
|
if (!vm().argument_count())
|
|
return js_symbol(heap(), "", false);
|
|
return js_symbol(heap(), vm().argument(0).to_string(global_object()), false);
|
|
}
|
|
|
|
// 20.4.1.1 Symbol ( [ description ] ), https://tc39.es/ecma262/#sec-symbol-description
|
|
Value SymbolConstructor::construct(Function&)
|
|
{
|
|
vm().throw_exception<TypeError>(global_object(), ErrorType::NotAConstructor, "Symbol");
|
|
return {};
|
|
}
|
|
|
|
// 20.4.2.2 Symbol.for ( key ), https://tc39.es/ecma262/#sec-symbol.for
|
|
JS_DEFINE_NATIVE_FUNCTION(SymbolConstructor::for_)
|
|
{
|
|
String description;
|
|
if (!vm.argument_count()) {
|
|
description = "undefined";
|
|
} else {
|
|
description = vm.argument(0).to_string(global_object);
|
|
}
|
|
|
|
return global_object.vm().get_global_symbol(description);
|
|
}
|
|
|
|
// 20.4.2.6 Symbol.keyFor ( sym ), https://tc39.es/ecma262/#sec-symbol.keyfor
|
|
JS_DEFINE_NATIVE_FUNCTION(SymbolConstructor::key_for)
|
|
{
|
|
auto argument = vm.argument(0);
|
|
if (!argument.is_symbol()) {
|
|
vm.throw_exception<TypeError>(global_object, ErrorType::NotASymbol, argument.to_string_without_side_effects());
|
|
return {};
|
|
}
|
|
|
|
auto& symbol = argument.as_symbol();
|
|
if (symbol.is_global())
|
|
return js_string(vm, symbol.description());
|
|
|
|
return js_undefined();
|
|
}
|
|
|
|
}
|