7327a28ccc
As mentioned on Discord earlier, we'll add these to all new functions going forward - this is the backfill. Reasons: - It makes you look at the spec, implementing based on MDN or V8 behavior is a no-go - It makes finding the various functions that are non-compliant easier, in the future everything should either have such a comment or, if it's not from the spec at all, a comment explaining why that is the case - It makes it easier to check whether a certain abstract operation is implemented in LibJS, not all of them use the same name as the spec. E.g. RejectPromise() is Promise::reject() - It makes it easier to reason about vm.arguments(), e.g. when the function has a rest parameter - It makes it easier to see whether a certain function is from a proposal or Annex B Also: - Add arguments to all functions and abstract operations that already had a comment - Fix some outdated section numbers - Replace some ecma-international.org URLs with tc39.es
90 lines
3.2 KiB
C++
90 lines
3.2 KiB
C++
/*
|
|
* Copyright (c) 2020, Matthew Olsson <mattco@serenityos.org>
|
|
* Copyright (c) 2021, Linus Groh <linusg@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibJS/Runtime/Array.h>
|
|
#include <LibJS/Runtime/Error.h>
|
|
#include <LibJS/Runtime/GlobalObject.h>
|
|
#include <LibJS/Runtime/ProxyConstructor.h>
|
|
#include <LibJS/Runtime/ProxyObject.h>
|
|
|
|
namespace JS {
|
|
|
|
// 10.5.14 ProxyCreate ( target, handler ), https://tc39.es/ecma262/#sec-proxycreate
|
|
static ProxyObject* proxy_create(GlobalObject& global_object, Value target, Value handler)
|
|
{
|
|
auto& vm = global_object.vm();
|
|
if (!target.is_object()) {
|
|
vm.throw_exception<TypeError>(global_object, ErrorType::ProxyConstructorBadType, "target", target.to_string_without_side_effects());
|
|
return {};
|
|
}
|
|
if (!handler.is_object()) {
|
|
vm.throw_exception<TypeError>(global_object, ErrorType::ProxyConstructorBadType, "handler", handler.to_string_without_side_effects());
|
|
return {};
|
|
}
|
|
return ProxyObject::create(global_object, target.as_object(), handler.as_object());
|
|
}
|
|
|
|
ProxyConstructor::ProxyConstructor(GlobalObject& global_object)
|
|
: NativeFunction(vm().names.Proxy, *global_object.function_prototype())
|
|
{
|
|
}
|
|
|
|
void ProxyConstructor::initialize(GlobalObject& global_object)
|
|
{
|
|
auto& vm = this->vm();
|
|
NativeFunction::initialize(global_object);
|
|
define_property(vm.names.length, Value(2), Attribute::Configurable);
|
|
u8 attr = Attribute::Writable | Attribute::Configurable;
|
|
define_native_function(vm.names.revocable, revocable, 2, attr);
|
|
}
|
|
|
|
ProxyConstructor::~ProxyConstructor()
|
|
{
|
|
}
|
|
|
|
// 28.2.1.1 Proxy ( target, handler ), https://tc39.es/ecma262/#sec-proxy-target-handler
|
|
Value ProxyConstructor::call()
|
|
{
|
|
auto& vm = this->vm();
|
|
vm.throw_exception<TypeError>(global_object(), ErrorType::ConstructorWithoutNew, vm.names.Proxy);
|
|
return {};
|
|
}
|
|
|
|
// 28.2.1.1 Proxy ( target, handler ), https://tc39.es/ecma262/#sec-proxy-target-handler
|
|
Value ProxyConstructor::construct(Function&)
|
|
{
|
|
auto& vm = this->vm();
|
|
return proxy_create(global_object(), vm.argument(0), vm.argument(1));
|
|
}
|
|
|
|
// 28.2.2.1 Proxy.revocable ( target, handler ), https://tc39.es/ecma262/#sec-proxy.revocable
|
|
JS_DEFINE_NATIVE_FUNCTION(ProxyConstructor::revocable)
|
|
{
|
|
auto* proxy = proxy_create(global_object, vm.argument(0), vm.argument(1));
|
|
if (vm.exception())
|
|
return {};
|
|
|
|
// 28.2.2.1.1 Proxy Revocation Functions, https://tc39.es/ecma262/#sec-proxy-revocation-functions
|
|
auto* revoker = NativeFunction::create(global_object, "", [proxy_handle = make_handle(proxy)](auto&, auto&) -> Value {
|
|
auto& proxy = const_cast<ProxyObject&>(*proxy_handle.cell());
|
|
if (proxy.is_revoked())
|
|
return js_undefined();
|
|
// NOTE: The spec wants us to unset [[ProxyTarget]] and [[ProxyHandler]],
|
|
// which is their way of revoking the Proxy - this might affect GC-ability,
|
|
// but AFAICT not doing that should be ok compatibility-wise.
|
|
proxy.revoke();
|
|
return js_undefined();
|
|
});
|
|
revoker->define_property(vm.names.length, Value(0));
|
|
|
|
auto* result = Object::create_empty(global_object);
|
|
result->define_property(vm.names.proxy, proxy);
|
|
result->define_property(vm.names.revoke, revoker);
|
|
return result;
|
|
}
|
|
|
|
}
|