5159f64117
TmpFS inodes rely on the call to Inode::one_ref_left() to unregister themselves from the inode cache in TmpFS. When moving various kernel classes to ListedRefCounted for safe unref() while participating on lists, I forgot to make ListedRefCounted check for (and call) one_ref_left() & will_be_destroyed() on the CRTP class.
39 lines
1.2 KiB
C++
39 lines
1.2 KiB
C++
/*
|
|
* Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/RefCounted.h>
|
|
|
|
namespace Kernel {
|
|
|
|
// ListedRefCounted<T> is a slot-in replacement for RefCounted<T> to use in classes
|
|
// that add themselves to a SpinlockProtected<IntrusiveList> when constructed.
|
|
// The custom unref() implementation here ensures that the the list is locked during
|
|
// unref(), and that the T is removed from the list before ~T() is invoked.
|
|
|
|
template<typename T>
|
|
class ListedRefCounted : public RefCountedBase {
|
|
public:
|
|
bool unref() const
|
|
{
|
|
auto new_ref_count = T::all_instances().with([&](auto& list) {
|
|
auto new_ref_count = deref_base();
|
|
if (new_ref_count == 0)
|
|
list.remove(const_cast<T&>(static_cast<T const&>(*this)));
|
|
return new_ref_count;
|
|
});
|
|
if (new_ref_count == 0) {
|
|
call_will_be_destroyed_if_present(static_cast<const T*>(this));
|
|
delete const_cast<T*>(static_cast<T const*>(this));
|
|
} else if (new_ref_count == 1) {
|
|
call_one_ref_left_if_present(static_cast<T const*>(this));
|
|
}
|
|
return new_ref_count == 0;
|
|
}
|
|
};
|
|
|
|
}
|