3c74dc9f4d
This patch adds two macros to declare per-type allocators: - JS_DECLARE_ALLOCATOR(TypeName) - JS_DEFINE_ALLOCATOR(TypeName) When used, they add a type-specific CellAllocator that the Heap will delegate allocation requests to. The result of this is that GC objects of the same type always end up within the same HeapBlock, drastically reducing the ability to perform type confusion attacks. It also improves HeapBlock utilization, since each block now has cells sized exactly to the type used within that block. (Previously we only had a handful of block sizes available, and most GC allocations ended up with a large amount of slack in their tails.) There is a small performance hit from this, but I'm sure we can make up for it elsewhere. Note that the old size-based allocators still exist, and we fall back to them for any type that doesn't have its own CellAllocator.
79 lines
2.7 KiB
C++
79 lines
2.7 KiB
C++
/*
|
|
* Copyright (c) 2021, Idan Horowitz <idan.horowitz@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibJS/Runtime/AbstractOperations.h>
|
|
#include <LibJS/Runtime/Error.h>
|
|
#include <LibJS/Runtime/GlobalObject.h>
|
|
#include <LibJS/Runtime/Iterator.h>
|
|
#include <LibJS/Runtime/WeakSet.h>
|
|
#include <LibJS/Runtime/WeakSetConstructor.h>
|
|
|
|
namespace JS {
|
|
|
|
JS_DEFINE_ALLOCATOR(WeakSetConstructor);
|
|
|
|
WeakSetConstructor::WeakSetConstructor(Realm& realm)
|
|
: NativeFunction(realm.vm().names.WeakSet.as_string(), realm.intrinsics().function_prototype())
|
|
{
|
|
}
|
|
|
|
void WeakSetConstructor::initialize(Realm& realm)
|
|
{
|
|
auto& vm = this->vm();
|
|
Base::initialize(realm);
|
|
|
|
// 24.4.2.1 WeakSet.prototype, https://tc39.es/ecma262/#sec-weakset.prototype
|
|
define_direct_property(vm.names.prototype, realm.intrinsics().weak_set_prototype(), 0);
|
|
|
|
define_direct_property(vm.names.length, Value(0), Attribute::Configurable);
|
|
}
|
|
|
|
// 24.4.1.1 WeakSet ( [ iterable ] ), https://tc39.es/ecma262/#sec-weakset-iterable
|
|
ThrowCompletionOr<Value> WeakSetConstructor::call()
|
|
{
|
|
auto& vm = this->vm();
|
|
|
|
// 1. If NewTarget is undefined, throw a TypeError exception.
|
|
return vm.throw_completion<TypeError>(ErrorType::ConstructorWithoutNew, vm.names.WeakSet);
|
|
}
|
|
|
|
// 24.4.1.1 WeakSet ( [ iterable ] ), https://tc39.es/ecma262/#sec-weakset-iterable
|
|
ThrowCompletionOr<NonnullGCPtr<Object>> WeakSetConstructor::construct(FunctionObject& new_target)
|
|
{
|
|
auto& vm = this->vm();
|
|
auto iterable = vm.argument(0);
|
|
|
|
// 2. Let set be ? OrdinaryCreateFromConstructor(NewTarget, "%WeakSet.prototype%", « [[WeakSetData]] »).
|
|
// 3. Set set.[[WeakSetData]] to a new empty List.
|
|
auto set = TRY(ordinary_create_from_constructor<WeakSet>(vm, new_target, &Intrinsics::weak_set_prototype));
|
|
|
|
// 4. If iterable is either undefined or null, return set.
|
|
if (iterable.is_nullish())
|
|
return set;
|
|
|
|
// 5. Let adder be ? Get(set, "add").
|
|
auto adder = TRY(set->get(vm.names.add));
|
|
|
|
// 6. If IsCallable(adder) is false, throw a TypeError exception.
|
|
if (!adder.is_function())
|
|
return vm.throw_completion<TypeError>(ErrorType::NotAFunction, "'add' property of WeakSet");
|
|
|
|
// 7. Let iteratorRecord be ? GetIterator(iterable, sync).
|
|
// 8. Repeat,
|
|
// a. Let next be ? IteratorStep(iteratorRecord).
|
|
// c. Let nextValue be ? IteratorValue(next).
|
|
(void)TRY(get_iterator_values(vm, iterable, [&](Value next_value) -> Optional<Completion> {
|
|
// d. Let status be Completion(Call(adder, set, « nextValue »)).
|
|
// e. IfAbruptCloseIterator(status, iteratorRecord).
|
|
TRY(JS::call(vm, adder.as_function(), set, next_value));
|
|
return {};
|
|
}));
|
|
|
|
// b. If next is false, return set.
|
|
return set;
|
|
}
|
|
|
|
}
|