
With this change, we now have ~1200 CellAllocators across both LibJS and LibWeb in a normal WebContent instance. This gives us a minimum heap size of 4.7 MiB in the scenario where we only have one cell allocated per type. Of course, in practice there will be many more of each type, so the effective overhead is quite a bit smaller than that in practice. I left a few types unconverted to this mechanism because I got tired of doing this. :^)
39 lines
1.3 KiB
C++
39 lines
1.3 KiB
C++
/*
|
|
* Copyright (c) 2021-2022, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/DeprecatedString.h>
|
|
#include <AK/Variant.h>
|
|
#include <LibJS/Heap/Cell.h>
|
|
#include <LibJS/Heap/CellAllocator.h>
|
|
#include <LibWeb/WebIDL/CallbackType.h>
|
|
|
|
namespace Web::HTML {
|
|
|
|
class EventHandler final : public JS::Cell {
|
|
JS_CELL(EventHandler, JS::Cell);
|
|
JS_DECLARE_ALLOCATOR(EventHandler);
|
|
|
|
public:
|
|
explicit EventHandler(DeprecatedString);
|
|
explicit EventHandler(WebIDL::CallbackType&);
|
|
|
|
// Either uncompiled source code or a callback.
|
|
// https://html.spec.whatwg.org/multipage/webappapis.html#event-handler-value
|
|
// NOTE: This does not contain Empty as part of the optimization of not allocating all event handler attributes up front.
|
|
// FIXME: The string should actually be an "internal raw uncompiled handler" struct. This struct is just the uncompiled source code plus a source location for reporting parse errors.
|
|
// https://html.spec.whatwg.org/multipage/webappapis.html#internal-raw-uncompiled-handler
|
|
Variant<DeprecatedString, JS::GCPtr<WebIDL::CallbackType>> value;
|
|
|
|
// https://html.spec.whatwg.org/multipage/webappapis.html#event-handler-listener
|
|
JS::GCPtr<DOM::DOMEventListener> listener;
|
|
|
|
private:
|
|
virtual void visit_edges(Cell::Visitor&) override;
|
|
};
|
|
|
|
}
|