3c74dc9f4d
This patch adds two macros to declare per-type allocators: - JS_DECLARE_ALLOCATOR(TypeName) - JS_DEFINE_ALLOCATOR(TypeName) When used, they add a type-specific CellAllocator that the Heap will delegate allocation requests to. The result of this is that GC objects of the same type always end up within the same HeapBlock, drastically reducing the ability to perform type confusion attacks. It also improves HeapBlock utilization, since each block now has cells sized exactly to the type used within that block. (Previously we only had a handful of block sizes available, and most GC allocations ended up with a large amount of slack in their tails.) There is a small performance hit from this, but I'm sure we can make up for it elsewhere. Note that the old size-based allocators still exist, and we fall back to them for any type that doesn't have its own CellAllocator.
46 lines
1.8 KiB
C++
46 lines
1.8 KiB
C++
/*
|
|
* Copyright (c) 2021, Linus Groh <linusg@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibJS/Runtime/FunctionObject.h>
|
|
#include <LibJS/Runtime/Realm.h>
|
|
|
|
namespace JS {
|
|
|
|
class WrappedFunction final : public FunctionObject {
|
|
JS_OBJECT(WrappedFunction, FunctionObject);
|
|
JS_DECLARE_ALLOCATOR(WrappedFunction);
|
|
|
|
public:
|
|
static ThrowCompletionOr<NonnullGCPtr<WrappedFunction>> create(Realm&, Realm& caller_realm, FunctionObject& target_function);
|
|
|
|
virtual ~WrappedFunction() = default;
|
|
|
|
virtual ThrowCompletionOr<Value> internal_call(Value this_argument, MarkedVector<Value> arguments_list) override;
|
|
|
|
// FIXME: Remove this (and stop inventing random internal slots that shouldn't exist, jeez)
|
|
virtual DeprecatedFlyString const& name() const override { return m_wrapped_target_function->name(); }
|
|
|
|
virtual Realm* realm() const override { return m_realm; }
|
|
|
|
FunctionObject const& wrapped_target_function() const { return m_wrapped_target_function; }
|
|
FunctionObject& wrapped_target_function() { return m_wrapped_target_function; }
|
|
|
|
private:
|
|
WrappedFunction(Realm&, FunctionObject&, Object& prototype);
|
|
|
|
virtual void visit_edges(Visitor&) override;
|
|
|
|
// Internal Slots of Wrapped Function Exotic Objects, https://tc39.es/proposal-shadowrealm/#table-internal-slots-of-wrapped-function-exotic-objects
|
|
NonnullGCPtr<FunctionObject> m_wrapped_target_function; // [[WrappedTargetFunction]]
|
|
NonnullGCPtr<Realm> m_realm; // [[Realm]]
|
|
};
|
|
|
|
ThrowCompletionOr<Value> ordinary_wrapped_function_call(WrappedFunction const&, Value this_argument, MarkedVector<Value> const& arguments_list);
|
|
void prepare_for_wrapped_function_call(WrappedFunction const&, ExecutionContext& callee_context);
|
|
|
|
}
|