1c4dd0caad
The main thread in the WebContent process is often busy with layout and running JavaScript. This can cause audio to sound jittery and crack. To avoid this behavior, we now drive audio on a secondary thread. Note: Browser on Serenity uses AudioServer, the connection for which is already handled on a secondary thread within LibAudio. So this only applies to Lagom. Rather than using LibThreading, our hands are tied to QThread for now. Internally, the Qt media objects use a QTimer, which is forbidden from running on a thread that is not a QThread (the debug console is spammed with messages pointing this out). Ideally, in the future AudioServer will be able to run for non-Serenity platforms, and most of this can be aligned with the Serenity implementation.
67 lines
1.9 KiB
C++
67 lines
1.9 KiB
C++
/*
|
|
* Copyright (c) 2023, Tim Flynn <trflynn89@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/String.h>
|
|
#include <AK/Time.h>
|
|
#include <LibAudio/Forward.h>
|
|
#include <LibWeb/Bindings/PlatformObject.h>
|
|
|
|
namespace Web::HTML {
|
|
|
|
class AudioTrack final : public Bindings::PlatformObject {
|
|
WEB_PLATFORM_OBJECT(AudioTrack, Bindings::PlatformObject);
|
|
|
|
public:
|
|
virtual ~AudioTrack() override;
|
|
|
|
void set_audio_track_list(Badge<AudioTrackList>, JS::GCPtr<AudioTrackList> audio_track_list) { m_audio_track_list = audio_track_list; }
|
|
|
|
void play(Badge<HTMLAudioElement>);
|
|
void pause(Badge<HTMLAudioElement>);
|
|
|
|
Duration duration();
|
|
void seek(double, MediaSeekMode);
|
|
|
|
void update_volume();
|
|
|
|
String const& id() const { return m_id; }
|
|
String const& kind() const { return m_kind; }
|
|
String const& label() const { return m_label; }
|
|
String const& language() const { return m_language; }
|
|
|
|
bool enabled() const { return m_enabled; }
|
|
void set_enabled(bool enabled);
|
|
|
|
private:
|
|
AudioTrack(JS::Realm&, JS::NonnullGCPtr<HTMLMediaElement>, NonnullRefPtr<Audio::Loader>);
|
|
|
|
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
|
|
virtual void visit_edges(Cell::Visitor&) override;
|
|
|
|
// https://html.spec.whatwg.org/multipage/media.html#dom-audiotrack-id
|
|
String m_id;
|
|
|
|
// https://html.spec.whatwg.org/multipage/media.html#dom-audiotrack-kind
|
|
String m_kind;
|
|
|
|
// https://html.spec.whatwg.org/multipage/media.html#dom-audiotrack-label
|
|
String m_label;
|
|
|
|
// https://html.spec.whatwg.org/multipage/media.html#dom-audiotrack-language
|
|
String m_language;
|
|
|
|
// https://html.spec.whatwg.org/multipage/media.html#dom-audiotrack-enabled
|
|
bool m_enabled { false };
|
|
|
|
JS::NonnullGCPtr<HTMLMediaElement> m_media_element;
|
|
JS::GCPtr<AudioTrackList> m_audio_track_list;
|
|
|
|
NonnullOwnPtr<Platform::AudioCodecPlugin> m_audio_plugin;
|
|
};
|
|
|
|
}
|