9e468579ce
Using mmap was quite punishing on inputs with lots of basic blocks, such as test262 tests with eval() in a loop that goes 64k times.. ~27% speed-up on language/literals/regexp/S7.8.5_A2.1_T2.js but presumably everything everywhere will benefit from this. :^)
65 lines
2 KiB
C++
65 lines
2 KiB
C++
/*
|
|
* Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <AK/DeprecatedString.h>
|
|
#include <LibJS/Bytecode/BasicBlock.h>
|
|
#include <LibJS/Bytecode/Op.h>
|
|
|
|
namespace JS::Bytecode {
|
|
|
|
NonnullOwnPtr<BasicBlock> BasicBlock::create(DeprecatedString name, size_t size)
|
|
{
|
|
return adopt_own(*new BasicBlock(move(name), max(size, static_cast<size_t>(4 * KiB))));
|
|
}
|
|
|
|
BasicBlock::BasicBlock(DeprecatedString name, size_t size)
|
|
: m_name(move(name))
|
|
{
|
|
// FIXME: This is not the smartest solution ever. Find something cleverer!
|
|
// The main issue we're working around here is that we don't want pointers into the bytecode stream to become invalidated
|
|
// during code generation due to dynamic buffer resizing. Otherwise we could just use a Vector.
|
|
m_buffer_capacity = size;
|
|
m_buffer = new u8[m_buffer_capacity];
|
|
}
|
|
|
|
BasicBlock::~BasicBlock()
|
|
{
|
|
Bytecode::InstructionStreamIterator it(instruction_stream());
|
|
while (!it.at_end()) {
|
|
auto& to_destroy = (*it);
|
|
++it;
|
|
Instruction::destroy(const_cast<Instruction&>(to_destroy));
|
|
}
|
|
|
|
delete[] m_buffer;
|
|
}
|
|
|
|
void BasicBlock::seal()
|
|
{
|
|
// FIXME: mprotect the instruction stream as PROT_READ
|
|
// This is currently not possible because instructions can have destructors (that clean up strings)
|
|
// Instructions should instead be destructor-less and refer to strings in a string table on the Bytecode::Block.
|
|
// It also doesn't work because instructions that have String members use RefPtr internally which must be in writable memory.
|
|
}
|
|
|
|
void BasicBlock::dump(Bytecode::Executable const& executable) const
|
|
{
|
|
Bytecode::InstructionStreamIterator it(instruction_stream());
|
|
if (!m_name.is_empty())
|
|
warnln("{}:", m_name);
|
|
while (!it.at_end()) {
|
|
warnln("[{:4x}] {}", it.offset(), (*it).to_deprecated_string(executable));
|
|
++it;
|
|
}
|
|
}
|
|
|
|
void BasicBlock::grow(size_t additional_size)
|
|
{
|
|
m_buffer_size += additional_size;
|
|
VERIFY(m_buffer_size <= m_buffer_capacity);
|
|
}
|
|
|
|
}
|