65232b6681
These cases were found with GCC's `-Wsuggest-final-{types,methods}`
warnings, which catch calls that could have been devirtualized had we
declared the functions `final` in the source.
To reproduce, Link Time Optimization needs to be enabled. The easiest
way to achieve this is to set the `CMAKE_INTERPROCEDURAL_OPTIMIZATION`
cache variable to `ON`. The `.incbin` directive in LibCompress' Brotli
decompressor might needs to be changed to an absolute path for this to
work.
This commit also removes a pair of unused virtual functions.
71 lines
2.8 KiB
C++
71 lines
2.8 KiB
C++
/*
|
|
* Copyright (c) 2020-2022, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/StringView.h>
|
|
#include <LibJS/Runtime/Completion.h>
|
|
#include <LibJS/Runtime/Object.h>
|
|
|
|
namespace JS {
|
|
|
|
struct Variable {
|
|
Value value;
|
|
DeclarationKind declaration_kind;
|
|
};
|
|
|
|
#define JS_ENVIRONMENT(class_, base_class) JS_CELL(class_, base_class)
|
|
|
|
class Environment : public Cell {
|
|
JS_CELL(Environment, Cell);
|
|
|
|
public:
|
|
enum class InitializeBindingHint {
|
|
Normal,
|
|
SyncDispose,
|
|
};
|
|
|
|
virtual bool has_this_binding() const { return false; }
|
|
virtual ThrowCompletionOr<Value> get_this_binding(VM&) const { return Value {}; }
|
|
|
|
virtual Object* with_base_object() const { return nullptr; }
|
|
|
|
virtual ThrowCompletionOr<bool> has_binding([[maybe_unused]] DeprecatedFlyString const& name, [[maybe_unused]] Optional<size_t>* out_index = nullptr) const { return false; }
|
|
virtual ThrowCompletionOr<void> create_mutable_binding(VM&, [[maybe_unused]] DeprecatedFlyString const& name, [[maybe_unused]] bool can_be_deleted) { return {}; }
|
|
virtual ThrowCompletionOr<void> create_immutable_binding(VM&, [[maybe_unused]] DeprecatedFlyString const& name, [[maybe_unused]] bool strict) { return {}; }
|
|
virtual ThrowCompletionOr<void> initialize_binding(VM&, [[maybe_unused]] DeprecatedFlyString const& name, Value, InitializeBindingHint) { return {}; }
|
|
virtual ThrowCompletionOr<void> set_mutable_binding(VM&, [[maybe_unused]] DeprecatedFlyString const& name, Value, [[maybe_unused]] bool strict) { return {}; }
|
|
virtual ThrowCompletionOr<Value> get_binding_value(VM&, [[maybe_unused]] DeprecatedFlyString const& name, [[maybe_unused]] bool strict) { return Value {}; }
|
|
virtual ThrowCompletionOr<bool> delete_binding(VM&, [[maybe_unused]] DeprecatedFlyString const& name) { return false; }
|
|
|
|
// [[OuterEnv]]
|
|
Environment* outer_environment() { return m_outer_environment; }
|
|
Environment const* outer_environment() const { return m_outer_environment; }
|
|
|
|
virtual bool is_global_environment() const { return false; }
|
|
virtual bool is_declarative_environment() const { return false; }
|
|
virtual bool is_function_environment() const { return false; }
|
|
|
|
template<typename T>
|
|
bool fast_is() const = delete;
|
|
|
|
// This flag is set on the entire variable environment chain when direct eval() is performed.
|
|
// It is used to disable non-local variable access caching.
|
|
bool is_permanently_screwed_by_eval() const { return m_permanently_screwed_by_eval; }
|
|
void set_permanently_screwed_by_eval();
|
|
|
|
protected:
|
|
explicit Environment(Environment* parent);
|
|
|
|
virtual void visit_edges(Visitor&) override;
|
|
|
|
private:
|
|
bool m_permanently_screwed_by_eval { false };
|
|
|
|
GCPtr<Environment> m_outer_environment;
|
|
};
|
|
|
|
}
|