077406dc36
1. Allow Value(size_t) and use it for array length properties. If an array length can't fit in an Int32 value, we shouldn't go out of or way to force it into one. Instead, for values above INT32_MAX, we simply store them as Double values. 2. Switch to generic indexed property storage for large arrays. Previously we would always allocate array storage eagerly when the length property was set. This meant that "a.length = 0x80000000" would trivially DOS the engine on 32-bit since we don't have that much VM. We now switch to generic storage when changing the length moves us over the 4M entry mark. Fixes #5986.
90 lines
3 KiB
C++
90 lines
3 KiB
C++
/*
|
|
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright notice, this
|
|
* list of conditions and the following disclaimer.
|
|
*
|
|
* 2. Redistributions in binary form must reproduce the above copyright notice,
|
|
* this list of conditions and the following disclaimer in the documentation
|
|
* and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
|
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
|
|
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
|
|
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
|
|
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include <AK/Function.h>
|
|
#include <LibJS/Runtime/Array.h>
|
|
#include <LibJS/Runtime/Error.h>
|
|
#include <LibJS/Runtime/GlobalObject.h>
|
|
|
|
namespace JS {
|
|
|
|
Array* Array::create(GlobalObject& global_object)
|
|
{
|
|
return global_object.heap().allocate<Array>(global_object, *global_object.array_prototype());
|
|
}
|
|
|
|
Array::Array(Object& prototype)
|
|
: Object(prototype)
|
|
{
|
|
}
|
|
|
|
void Array::initialize(GlobalObject& global_object)
|
|
{
|
|
auto& vm = this->vm();
|
|
Object::initialize(global_object);
|
|
define_native_property(vm.names.length, length_getter, length_setter, Attribute::Writable);
|
|
}
|
|
|
|
Array::~Array()
|
|
{
|
|
}
|
|
|
|
Array* Array::typed_this(VM& vm, GlobalObject& global_object)
|
|
{
|
|
auto* this_object = vm.this_value(global_object).to_object(global_object);
|
|
if (!this_object)
|
|
return {};
|
|
if (!this_object->is_array()) {
|
|
vm.throw_exception<TypeError>(global_object, ErrorType::NotAn, "Array");
|
|
return nullptr;
|
|
}
|
|
return static_cast<Array*>(this_object);
|
|
}
|
|
|
|
JS_DEFINE_NATIVE_GETTER(Array::length_getter)
|
|
{
|
|
auto* array = typed_this(vm, global_object);
|
|
if (!array)
|
|
return {};
|
|
return Value(array->indexed_properties().array_like_size());
|
|
}
|
|
|
|
JS_DEFINE_NATIVE_SETTER(Array::length_setter)
|
|
{
|
|
auto* array = typed_this(vm, global_object);
|
|
if (!array)
|
|
return;
|
|
auto length = value.to_number(global_object);
|
|
if (vm.exception())
|
|
return;
|
|
if (length.is_nan() || length.is_infinity() || length.as_double() < 0) {
|
|
vm.throw_exception<RangeError>(global_object, ErrorType::InvalidLength, "array");
|
|
return;
|
|
}
|
|
array->indexed_properties().set_array_like_size(length.as_double());
|
|
}
|
|
|
|
}
|