Validation.cpp 12 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318
  1. /*
  2. * Copyright (c) 2020, Andrew Kaster <akaster@serenityos.org>
  3. * Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
  4. *
  5. * SPDX-License-Identifier: BSD-2-Clause
  6. */
  7. #include <AK/Assertions.h>
  8. #include <AK/Checked.h>
  9. #include <LibC/elf.h>
  10. #include <LibELF/Validation.h>
  11. #include <limits.h>
  12. namespace ELF {
  13. bool validate_elf_header(ElfW(Ehdr) const& elf_header, size_t file_size, bool verbose)
  14. {
  15. if (!IS_ELF(elf_header)) {
  16. if (verbose)
  17. dbgln("File is not an ELF file.");
  18. return false;
  19. }
  20. #if ARCH(I386)
  21. auto expected_class = ELFCLASS32;
  22. auto expected_bitness = 32;
  23. #else
  24. auto expected_class = ELFCLASS64;
  25. auto expected_bitness = 64;
  26. #endif
  27. if (expected_class != elf_header.e_ident[EI_CLASS]) {
  28. if (verbose)
  29. dbgln("File is not a {}-bit ELF file.", expected_bitness);
  30. return false;
  31. }
  32. if (ELFDATA2LSB != elf_header.e_ident[EI_DATA]) {
  33. if (verbose)
  34. dbgln("File is not a little endian ELF file.");
  35. return false;
  36. }
  37. if (EV_CURRENT != elf_header.e_ident[EI_VERSION]) {
  38. if (verbose)
  39. dbgln("File has unrecognized ELF version ({}), expected ({})!", elf_header.e_ident[EI_VERSION], EV_CURRENT);
  40. return false;
  41. }
  42. if (ELFOSABI_SYSV != elf_header.e_ident[EI_OSABI]) {
  43. if (verbose)
  44. dbgln("File has unknown OS ABI ({}), expected SYSV(0)!", elf_header.e_ident[EI_OSABI]);
  45. return false;
  46. }
  47. if (0 != elf_header.e_ident[EI_ABIVERSION]) {
  48. if (verbose)
  49. dbgln("File has unknown SYSV ABI version ({})!", elf_header.e_ident[EI_ABIVERSION]);
  50. return false;
  51. }
  52. #if ARCH(I386)
  53. auto expected_machine = EM_386;
  54. auto expected_machine_name = "i386";
  55. #else
  56. auto expected_machine = EM_X86_64;
  57. auto expected_machine_name = "x86-64";
  58. #endif
  59. if (expected_machine != elf_header.e_machine) {
  60. if (verbose)
  61. dbgln("File has unknown machine ({}), expected {} ({})!", elf_header.e_machine, expected_machine_name, expected_machine);
  62. return false;
  63. }
  64. if (ET_EXEC != elf_header.e_type && ET_DYN != elf_header.e_type && ET_REL != elf_header.e_type && ET_CORE != elf_header.e_type) {
  65. if (verbose)
  66. dbgln("File has unloadable ELF type ({}), expected REL (1), EXEC (2), DYN (3) or CORE(4)!", elf_header.e_type);
  67. return false;
  68. }
  69. if (EV_CURRENT != elf_header.e_version) {
  70. if (verbose)
  71. dbgln("File has unrecognized ELF version ({}), expected ({})!", elf_header.e_version, EV_CURRENT);
  72. return false;
  73. }
  74. if (sizeof(ElfW(Ehdr)) != elf_header.e_ehsize) {
  75. if (verbose)
  76. dbgln("File has incorrect ELF header size..? ({}), expected ({})!", elf_header.e_ehsize, sizeof(ElfW(Ehdr)));
  77. return false;
  78. }
  79. if ((elf_header.e_phnum != 0 && elf_header.e_phoff < elf_header.e_ehsize) || (elf_header.e_shnum != SHN_UNDEF && elf_header.e_shoff < elf_header.e_ehsize)) {
  80. if (verbose) {
  81. dbgln("SHENANIGANS! program header offset ({}) or section header offset ({}) overlap with ELF header!",
  82. elf_header.e_phoff, elf_header.e_shoff);
  83. }
  84. return false;
  85. }
  86. if (elf_header.e_phoff > file_size || elf_header.e_shoff > file_size) {
  87. if (verbose) {
  88. dbgln("SHENANIGANS! program header offset ({}) or section header offset ({}) are past the end of the file!",
  89. elf_header.e_phoff, elf_header.e_shoff);
  90. }
  91. return false;
  92. }
  93. if (elf_header.e_phnum == 0 && elf_header.e_phoff != 0) {
  94. if (verbose)
  95. dbgln("SHENANIGANS! File has no program headers, but it does have a program header offset ({})!", elf_header.e_phoff);
  96. return false;
  97. }
  98. if (elf_header.e_phnum != 0 && elf_header.e_phoff != elf_header.e_ehsize) {
  99. if (verbose) {
  100. dbgln("File does not have program headers directly after the ELF header? program header offset ({}), expected ({}).",
  101. elf_header.e_phoff, elf_header.e_ehsize);
  102. }
  103. return false;
  104. }
  105. if (0 != elf_header.e_flags) {
  106. if (verbose)
  107. dbgln("File has incorrect ELF header flags...? ({}), expected ({}).", elf_header.e_flags, 0);
  108. return false;
  109. }
  110. if (0 != elf_header.e_phnum && sizeof(ElfW(Phdr)) != elf_header.e_phentsize) {
  111. if (verbose)
  112. dbgln("File has incorrect program header size..? ({}), expected ({}).", elf_header.e_phentsize, sizeof(ElfW(Phdr)));
  113. return false;
  114. }
  115. if (sizeof(ElfW(Shdr)) != elf_header.e_shentsize) {
  116. if (verbose)
  117. dbgln("File has incorrect section header size..? ({}), expected ({}).", elf_header.e_shentsize, sizeof(ElfW(Shdr)));
  118. return false;
  119. }
  120. Checked<size_t> total_size_of_program_headers = elf_header.e_phnum;
  121. total_size_of_program_headers *= elf_header.e_phentsize;
  122. Checked<size_t> end_of_last_program_header = elf_header.e_phoff;
  123. end_of_last_program_header += total_size_of_program_headers;
  124. if (end_of_last_program_header.has_overflow()) {
  125. if (verbose)
  126. dbgln("SHENANIGANS! Integer overflow in program header validation");
  127. return false;
  128. }
  129. if (end_of_last_program_header > file_size) {
  130. if (verbose)
  131. dbgln("SHENANIGANS! End of last program header ({}) is past the end of the file!", end_of_last_program_header.value());
  132. return false;
  133. }
  134. if (elf_header.e_shoff != SHN_UNDEF && elf_header.e_shoff < end_of_last_program_header.value()) {
  135. if (verbose) {
  136. dbgln("SHENANIGANS! Section header table begins at file offset {}, which is within program headers [ {} - {} ]!",
  137. elf_header.e_shoff, elf_header.e_phoff, end_of_last_program_header.value());
  138. }
  139. return false;
  140. }
  141. Checked<size_t> total_size_of_section_headers = elf_header.e_shnum;
  142. total_size_of_section_headers *= elf_header.e_shentsize;
  143. Checked<size_t> end_of_last_section_header = elf_header.e_shoff;
  144. end_of_last_section_header += total_size_of_section_headers;
  145. if (end_of_last_section_header.has_overflow()) {
  146. if (verbose)
  147. dbgln("SHENANIGANS! Integer overflow in section header validation");
  148. return false;
  149. }
  150. if (end_of_last_section_header > file_size) {
  151. if (verbose)
  152. dbgln("SHENANIGANS! End of last section header ({}) is past the end of the file!", end_of_last_section_header.value());
  153. return false;
  154. }
  155. if (elf_header.e_shstrndx != SHN_UNDEF && elf_header.e_shstrndx >= elf_header.e_shnum) {
  156. if (verbose)
  157. dbgln("SHENANIGANS! Section header string table index ({}) is not a valid index given we have {} section headers!", elf_header.e_shstrndx, elf_header.e_shnum);
  158. return false;
  159. }
  160. return true;
  161. }
  162. ErrorOr<bool> validate_program_headers(ElfW(Ehdr) const& elf_header, size_t file_size, ReadonlyBytes buffer, StringBuilder* interpreter_path_builder, bool verbose)
  163. {
  164. Checked<size_t> total_size_of_program_headers = elf_header.e_phnum;
  165. total_size_of_program_headers *= elf_header.e_phentsize;
  166. Checked<size_t> end_of_last_program_header = elf_header.e_phoff;
  167. end_of_last_program_header += total_size_of_program_headers;
  168. if (end_of_last_program_header.has_overflow()) {
  169. if (verbose)
  170. dbgln("SHENANIGANS! Integer overflow in program header validation");
  171. return false;
  172. }
  173. // Can we actually parse all the program headers in the given buffer?
  174. if (end_of_last_program_header > buffer.size()) {
  175. if (verbose)
  176. dbgln("Unable to parse program headers from buffer, buffer too small! Buffer size: {}, End of program headers {}", buffer.size(), end_of_last_program_header.value());
  177. return false;
  178. }
  179. if (file_size < buffer.size()) {
  180. dbgln("We somehow read more from a file than was in the file in the first place!");
  181. VERIFY_NOT_REACHED();
  182. }
  183. size_t num_program_headers = elf_header.e_phnum;
  184. auto program_header_begin = (const ElfW(Phdr)*)buffer.offset(elf_header.e_phoff);
  185. for (size_t header_index = 0; header_index < num_program_headers; ++header_index) {
  186. auto& program_header = program_header_begin[header_index];
  187. if (program_header.p_filesz > program_header.p_memsz) {
  188. if (verbose)
  189. dbgln("Program header ({}) has p_filesz ({}) larger than p_memsz ({})", header_index, program_header.p_filesz, program_header.p_memsz);
  190. return false;
  191. }
  192. if (elf_header.e_type != ET_CORE) {
  193. if (program_header.p_type == PT_LOAD && program_header.p_align == 0) {
  194. if (verbose)
  195. dbgln("Program header ({}) with p_type PT_LOAD missing p_align (p_align == 0)", header_index);
  196. return false;
  197. }
  198. if (program_header.p_type == PT_LOAD && program_header.p_align % (size_t)PAGE_SIZE != 0) {
  199. if (verbose)
  200. dbgln("Program header ({}) with p_type PT_LOAD has p_align ({}) not divisible by page size ({})", header_index, program_header.p_align, PAGE_SIZE);
  201. return false;
  202. }
  203. if (program_header.p_type == PT_LOAD && program_header.p_vaddr % program_header.p_align != program_header.p_offset % program_header.p_align) {
  204. if (verbose)
  205. dbgln("Program header ({}) with p_type PT_LOAD has mis-aligned p_vaddr ({:x})", header_index, program_header.p_vaddr);
  206. return false;
  207. }
  208. }
  209. switch (program_header.p_type) {
  210. case PT_INTERP:
  211. // We checked above that file_size was >= buffer size. We only care about buffer size anyway, we're trying to read this!
  212. if (Checked<size_t>::addition_would_overflow(program_header.p_offset, program_header.p_filesz)) {
  213. if (verbose)
  214. dbgln("Integer overflow while validating PT_INTERP header");
  215. return false;
  216. }
  217. if (program_header.p_offset + program_header.p_filesz > buffer.size()) {
  218. if (verbose)
  219. dbgln("Found PT_INTERP header ({}), but the .interp section was not within the buffer :(", header_index);
  220. return false;
  221. }
  222. if (program_header.p_filesz <= 1) {
  223. if (verbose)
  224. dbgln("Found PT_INTERP header ({}), but p_filesz is invalid ({})", header_index, program_header.p_filesz);
  225. return false;
  226. }
  227. if (interpreter_path_builder)
  228. TRY(interpreter_path_builder->try_append({ buffer.offset(program_header.p_offset), program_header.p_filesz - 1 }));
  229. break;
  230. case PT_LOAD:
  231. case PT_DYNAMIC:
  232. case PT_GNU_EH_FRAME:
  233. case PT_NOTE:
  234. case PT_PHDR:
  235. case PT_TLS:
  236. if (Checked<size_t>::addition_would_overflow(program_header.p_offset, program_header.p_filesz)) {
  237. if (verbose)
  238. dbgln("Integer overflow while validating a program header");
  239. return false;
  240. }
  241. if (program_header.p_offset + program_header.p_filesz > file_size) {
  242. if (verbose)
  243. dbgln("SHENANIGANS! Program header {} segment leaks beyond end of file!", header_index);
  244. return false;
  245. }
  246. if ((program_header.p_flags & PF_X) && (program_header.p_flags & PF_W)) {
  247. if (verbose)
  248. dbgln("SHENANIGANS! Program header {} segment is marked write and execute", header_index);
  249. return false;
  250. }
  251. break;
  252. case PT_GNU_STACK:
  253. if (program_header.p_flags & PF_X) {
  254. if (verbose)
  255. dbgln("Possible shenanigans! Validating an ELF with executable stack.");
  256. }
  257. break;
  258. case PT_GNU_RELRO:
  259. if ((program_header.p_flags & PF_X) && (program_header.p_flags & PF_W)) {
  260. if (verbose)
  261. dbgln("SHENANIGANS! Program header {} segment is marked write and execute", header_index);
  262. return false;
  263. }
  264. break;
  265. default:
  266. // Not handling other program header types in other code so... let's not surprise them
  267. if (verbose)
  268. dbgln("Found program header ({}) of unrecognized type {}!", header_index, program_header.p_type);
  269. return false;
  270. }
  271. }
  272. return true;
  273. }
  274. } // end namespace ELF