Validation.cpp 13 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325
  1. /*
  2. * Copyright (c) 2020, Andrew Kaster <akaster@serenityos.org>
  3. * Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
  4. *
  5. * SPDX-License-Identifier: BSD-2-Clause
  6. */
  7. #include <AK/Assertions.h>
  8. #include <AK/Checked.h>
  9. #include <AK/String.h>
  10. #include <LibC/elf.h>
  11. #include <LibELF/Validation.h>
  12. #include <limits.h>
  13. namespace ELF {
  14. bool validate_elf_header(const ElfW(Ehdr) & elf_header, size_t file_size, bool verbose)
  15. {
  16. if (!IS_ELF(elf_header)) {
  17. if (verbose)
  18. dbgln("File is not an ELF file.");
  19. return false;
  20. }
  21. #if ARCH(I386)
  22. auto expected_class = ELFCLASS32;
  23. auto expected_bitness = 32;
  24. #else
  25. auto expected_class = ELFCLASS64;
  26. auto expected_bitness = 64;
  27. #endif
  28. if (expected_class != elf_header.e_ident[EI_CLASS]) {
  29. if (verbose)
  30. dbgln("File is not a {}-bit ELF file.", expected_bitness);
  31. return false;
  32. }
  33. if (ELFDATA2LSB != elf_header.e_ident[EI_DATA]) {
  34. if (verbose)
  35. dbgln("File is not a little endian ELF file.");
  36. return false;
  37. }
  38. if (EV_CURRENT != elf_header.e_ident[EI_VERSION]) {
  39. if (verbose)
  40. dbgln("File has unrecognized ELF version ({}), expected ({})!", elf_header.e_ident[EI_VERSION], EV_CURRENT);
  41. return false;
  42. }
  43. if (ELFOSABI_SYSV != elf_header.e_ident[EI_OSABI]) {
  44. if (verbose)
  45. dbgln("File has unknown OS ABI ({}), expected SYSV(0)!", elf_header.e_ident[EI_OSABI]);
  46. return false;
  47. }
  48. if (0 != elf_header.e_ident[EI_ABIVERSION]) {
  49. if (verbose)
  50. dbgln("File has unknown SYSV ABI version ({})!", elf_header.e_ident[EI_ABIVERSION]);
  51. return false;
  52. }
  53. #if ARCH(I386)
  54. auto expected_machine = EM_386;
  55. auto expected_machine_name = "i386";
  56. #else
  57. auto expected_machine = EM_X86_64;
  58. auto expected_machine_name = "x86-64";
  59. #endif
  60. if (expected_machine != elf_header.e_machine) {
  61. if (verbose)
  62. dbgln("File has unknown machine ({}), expected {} ({})!", elf_header.e_machine, expected_machine_name, expected_machine);
  63. return false;
  64. }
  65. if (ET_EXEC != elf_header.e_type && ET_DYN != elf_header.e_type && ET_REL != elf_header.e_type && ET_CORE != elf_header.e_type) {
  66. if (verbose)
  67. dbgln("File has unloadable ELF type ({}), expected REL (1), EXEC (2), DYN (3) or CORE(4)!", elf_header.e_type);
  68. return false;
  69. }
  70. if (EV_CURRENT != elf_header.e_version) {
  71. if (verbose)
  72. dbgln("File has unrecognized ELF version ({}), expected ({})!", elf_header.e_version, EV_CURRENT);
  73. return false;
  74. }
  75. if (sizeof(ElfW(Ehdr)) != elf_header.e_ehsize) {
  76. if (verbose)
  77. dbgln("File has incorrect ELF header size..? ({}), expected ({})!", elf_header.e_ehsize, sizeof(ElfW(Ehdr)));
  78. return false;
  79. }
  80. if ((elf_header.e_phnum != 0 && elf_header.e_phoff < elf_header.e_ehsize) || (elf_header.e_shnum != SHN_UNDEF && elf_header.e_shoff < elf_header.e_ehsize)) {
  81. if (verbose) {
  82. dbgln("SHENANIGANS! program header offset ({}) or section header offset ({}) overlap with ELF header!",
  83. elf_header.e_phoff, elf_header.e_shoff);
  84. }
  85. return false;
  86. }
  87. if (elf_header.e_phoff > file_size || elf_header.e_shoff > file_size) {
  88. if (verbose) {
  89. dbgln("SHENANIGANS! program header offset ({}) or section header offset ({}) are past the end of the file!",
  90. elf_header.e_phoff, elf_header.e_shoff);
  91. }
  92. return false;
  93. }
  94. if (elf_header.e_phnum == 0 && elf_header.e_phoff != 0) {
  95. if (verbose)
  96. dbgln("SHENANIGANS! File has no program headers, but it does have a program header offset ({})!", elf_header.e_phoff);
  97. return false;
  98. }
  99. if (elf_header.e_phnum != 0 && elf_header.e_phoff != elf_header.e_ehsize) {
  100. if (verbose) {
  101. dbgln("File does not have program headers directly after the ELF header? program header offset ({}), expected ({}).",
  102. elf_header.e_phoff, elf_header.e_ehsize);
  103. }
  104. return false;
  105. }
  106. if (0 != elf_header.e_flags) {
  107. if (verbose)
  108. dbgln("File has incorrect ELF header flags...? ({}), expected ({}).", elf_header.e_flags, 0);
  109. return false;
  110. }
  111. if (0 != elf_header.e_phnum && sizeof(ElfW(Phdr)) != elf_header.e_phentsize) {
  112. if (verbose)
  113. dbgln("File has incorrect program header size..? ({}), expected ({}).", elf_header.e_phentsize, sizeof(ElfW(Phdr)));
  114. return false;
  115. }
  116. if (sizeof(ElfW(Shdr)) != elf_header.e_shentsize) {
  117. if (verbose)
  118. dbgln("File has incorrect section header size..? ({}), expected ({}).", elf_header.e_shentsize, sizeof(ElfW(Shdr)));
  119. return false;
  120. }
  121. Checked<size_t> total_size_of_program_headers = elf_header.e_phnum;
  122. total_size_of_program_headers *= elf_header.e_phentsize;
  123. Checked<size_t> end_of_last_program_header = elf_header.e_phoff;
  124. end_of_last_program_header += total_size_of_program_headers;
  125. if (end_of_last_program_header.has_overflow()) {
  126. if (verbose)
  127. dbgln("SHENANIGANS! Integer overflow in program header validation");
  128. return false;
  129. }
  130. if (end_of_last_program_header > file_size) {
  131. if (verbose)
  132. dbgln("SHENANIGANS! End of last program header ({}) is past the end of the file!", end_of_last_program_header.value());
  133. return false;
  134. }
  135. if (elf_header.e_shoff != SHN_UNDEF && elf_header.e_shoff < end_of_last_program_header.value()) {
  136. if (verbose) {
  137. dbgln("SHENANIGANS! Section header table begins at file offset {}, which is within program headers [ {} - {} ]!",
  138. elf_header.e_shoff, elf_header.e_phoff, end_of_last_program_header.value());
  139. }
  140. return false;
  141. }
  142. Checked<size_t> total_size_of_section_headers = elf_header.e_shnum;
  143. total_size_of_section_headers *= elf_header.e_shentsize;
  144. Checked<size_t> end_of_last_section_header = elf_header.e_shoff;
  145. end_of_last_section_header += total_size_of_section_headers;
  146. if (end_of_last_section_header.has_overflow()) {
  147. if (verbose)
  148. dbgln("SHENANIGANS! Integer overflow in section header validation");
  149. return false;
  150. }
  151. if (end_of_last_section_header > file_size) {
  152. if (verbose)
  153. dbgln("SHENANIGANS! End of last section header ({}) is past the end of the file!", end_of_last_section_header.value());
  154. return false;
  155. }
  156. if (elf_header.e_shstrndx != SHN_UNDEF && elf_header.e_shstrndx >= elf_header.e_shnum) {
  157. if (verbose)
  158. dbgln("SHENANIGANS! Section header string table index ({}) is not a valid index given we have {} section headers!", elf_header.e_shstrndx, elf_header.e_shnum);
  159. return false;
  160. }
  161. return true;
  162. }
  163. bool validate_program_headers(const ElfW(Ehdr) & elf_header, size_t file_size, const u8* buffer, size_t buffer_size, String* interpreter_path, bool verbose)
  164. {
  165. Checked<size_t> total_size_of_program_headers = elf_header.e_phnum;
  166. total_size_of_program_headers *= elf_header.e_phentsize;
  167. Checked<size_t> end_of_last_program_header = elf_header.e_phoff;
  168. end_of_last_program_header += total_size_of_program_headers;
  169. if (end_of_last_program_header.has_overflow()) {
  170. if (verbose)
  171. dbgln("SHENANIGANS! Integer overflow in program header validation");
  172. return false;
  173. }
  174. // Can we actually parse all the program headers in the given buffer?
  175. if (end_of_last_program_header > buffer_size) {
  176. if (verbose)
  177. dbgln("Unable to parse program headers from buffer, buffer too small! Buffer size: {}, End of program headers {}", buffer_size, end_of_last_program_header.value());
  178. return false;
  179. }
  180. if (file_size < buffer_size) {
  181. dbgln("We somehow read more from a file than was in the file in the first place!");
  182. VERIFY_NOT_REACHED();
  183. }
  184. size_t num_program_headers = elf_header.e_phnum;
  185. auto program_header_begin = (const ElfW(Phdr)*)&(buffer[elf_header.e_phoff]);
  186. for (size_t header_index = 0; header_index < num_program_headers; ++header_index) {
  187. auto& program_header = program_header_begin[header_index];
  188. if (program_header.p_filesz > program_header.p_memsz) {
  189. if (verbose)
  190. dbgln("Program header ({}) has p_filesz ({}) larger than p_memsz ({})", header_index, program_header.p_filesz, program_header.p_memsz);
  191. return false;
  192. }
  193. if (program_header.p_memsz <= 0 && (program_header.p_type == PT_TLS || program_header.p_type == PT_LOAD)) {
  194. if (verbose)
  195. dbgln("Program header ({}) has invalid size in memory ({})", header_index, program_header.p_memsz);
  196. return false;
  197. }
  198. if (elf_header.e_type != ET_CORE) {
  199. if (program_header.p_type == PT_LOAD && program_header.p_align == 0) {
  200. if (verbose)
  201. dbgln("Program header ({}) with p_type PT_LOAD missing p_align (p_align == 0)", header_index);
  202. return false;
  203. }
  204. if (program_header.p_type == PT_LOAD && program_header.p_align % (size_t)PAGE_SIZE != 0) {
  205. if (verbose)
  206. dbgln("Program header ({}) with p_type PT_LOAD has p_align ({}) not divisible by page size ({})", header_index, program_header.p_align, PAGE_SIZE);
  207. return false;
  208. }
  209. if (program_header.p_type == PT_LOAD && program_header.p_vaddr % program_header.p_align != program_header.p_offset % program_header.p_align) {
  210. if (verbose)
  211. dbgln("Program header ({}) with p_type PT_LOAD has mis-aligned p_vaddr ({:x})", header_index, program_header.p_vaddr);
  212. return false;
  213. }
  214. }
  215. switch (program_header.p_type) {
  216. case PT_INTERP:
  217. // We checked above that file_size was >= buffer size. We only care about buffer size anyway, we're trying to read this!
  218. if (Checked<size_t>::addition_would_overflow(program_header.p_offset, program_header.p_filesz)) {
  219. if (verbose)
  220. dbgln("Integer overflow while validating PT_INTERP header");
  221. return false;
  222. }
  223. if (program_header.p_offset + program_header.p_filesz > buffer_size) {
  224. if (verbose)
  225. dbgln("Found PT_INTERP header ({}), but the .interp section was not within the buffer :(", header_index);
  226. return false;
  227. }
  228. if (program_header.p_filesz <= 1) {
  229. if (verbose)
  230. dbgln("Found PT_INTERP header ({}), but p_filesz is invalid ({})", header_index, program_header.p_filesz);
  231. return false;
  232. }
  233. if (interpreter_path)
  234. *interpreter_path = String((const char*)&buffer[program_header.p_offset], program_header.p_filesz - 1);
  235. break;
  236. case PT_LOAD:
  237. case PT_DYNAMIC:
  238. case PT_GNU_EH_FRAME:
  239. case PT_NOTE:
  240. case PT_PHDR:
  241. case PT_TLS:
  242. if (Checked<size_t>::addition_would_overflow(program_header.p_offset, program_header.p_filesz)) {
  243. if (verbose)
  244. dbgln("Integer overflow while validating a program header");
  245. return false;
  246. }
  247. if (program_header.p_offset + program_header.p_filesz > file_size) {
  248. if (verbose)
  249. dbgln("SHENANIGANS! Program header {} segment leaks beyond end of file!", header_index);
  250. return false;
  251. }
  252. if ((program_header.p_flags & PF_X) && (program_header.p_flags & PF_W)) {
  253. if (verbose)
  254. dbgln("SHENANIGANS! Program header {} segment is marked write and execute", header_index);
  255. return false;
  256. }
  257. break;
  258. case PT_GNU_STACK:
  259. if (program_header.p_flags & PF_X) {
  260. if (verbose)
  261. dbgln("Possible shenanigans! Validating an ELF with executable stack.");
  262. }
  263. break;
  264. case PT_GNU_RELRO:
  265. if ((program_header.p_flags & PF_X) && (program_header.p_flags & PF_W)) {
  266. if (verbose)
  267. dbgln("SHENANIGANS! Program header {} segment is marked write and execute", header_index);
  268. return false;
  269. }
  270. break;
  271. default:
  272. // Not handling other program header types in other code so... let's not surprise them
  273. if (verbose)
  274. dbgln("Found program header ({}) of unrecognized type {}!", header_index, program_header.p_type);
  275. return false;
  276. }
  277. }
  278. return true;
  279. }
  280. } // end namespace ELF