We use cookies to ensure you get the best experience on our website
Home Explore Help
Register Sign In
0ct0pu5
/
ladybird
1
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

LibWeb: Invalidate paint-only property after relayout

Before this change, `set_needs_to_resolve_paint_only_properties()` was
only called after style invalidation. However, since relayout can be
triggered independently from style invalidation, we need to ensure that
paint-only properties are updated in that case too.
Aliaksandr Kalenik 1 year ago
parent
e8a20b3c3e
commit
ff3e454565
3 changed files with 31 additions and 1 deletions
Split View Show Diff Stats
  1. 11 0
      Tests/LibWeb/Ref/reference/resolve-paint-only-properties-after-layout-ref.html
  2. 17 0
      Tests/LibWeb/Ref/resolve-paint-only-properties-after-layout.html
  3. 3 1
      Userland/Libraries/LibWeb/DOM/Document.cpp

+ 11 - 0
Tests/LibWeb/Ref/reference/resolve-paint-only-properties-after-layout-ref.html
View File 

@@ -0,0 +1,11 @@
 
+<!DOCTYPE html>
 
+<link rel="match" href="reference/resolve-paint-only-properties-after-layout-ref.html" />
 
+<style>
 
+    #box {
 
+        width: 100px;
 
+        height: 100px;
 
+        background-color: red;
 
+        border-radius: 50px;
 
+    }
 
+</style>
 
+<div id="box">hello</div>

+ 17 - 0
Tests/LibWeb/Ref/resolve-paint-only-properties-after-layout.html
View File 

@@ -0,0 +1,17 @@
 
+<!DOCTYPE html>
 
+<link rel="match" href="reference/resolve-paint-only-properties-after-layout-ref.html" />
 
+<style>
 
+    #box {
 
+        width: 100px;
 
+        height: 100px;
 
+        background-color: red;
 
+        border-radius: 50px;
 
+    }
 
+</style>
 
+<div id="box"></div>
 
+<script>
 
+    window.onload = function () {
 
+        const box = document.getElementById("box");
 
+        box.innerHTML = 'hello';        
+    };
 
+</script>

+ 3 - 1
Userland/Libraries/LibWeb/DOM/Document.cpp
View File 

@@ -1060,8 +1060,10 @@ void Document::update_layout()
 
     // Broadcast the current viewport rect to any new paintables, so they know whether they're visible or not.
 
     inform_all_viewport_clients_about_the_current_viewport_rect();
 
 
-    if (navigable())
 
+    if (navigable()) {
 
+        navigable()->set_needs_to_resolve_paint_only_properties();
 
         navigable()->set_needs_display();
 
+    }
 
 
     if (navigable()->is_traversable()) {
 
         page().client().page_did_layout();

Contact | Legal | Takedown | Status
Self-hosted public services - About
NibbleSpot by 0ct0pu5