Browse Source

LibJS: Use Value::to_boolean() wherever we haven't checked is_boolean()

Unless we've verified that a Value is a boolean, we should not be
calling as_bool() on it.
Andreas Kling 5 years ago
parent
commit
fe6bd9650f
1 changed files with 2 additions and 2 deletions
  1. 2 2
      Libraries/LibJS/AST.cpp

+ 2 - 2
Libraries/LibJS/AST.cpp

@@ -191,7 +191,7 @@ Value BinaryExpression::execute(Interpreter& interpreter) const
     case BinaryOp::TypedEquals:
         return typed_eq(lhs_result, rhs_result);
     case BinaryOp::TypedInequals:
-        return Value(!typed_eq(lhs_result, rhs_result).as_bool());
+        return Value(!typed_eq(lhs_result, rhs_result).to_boolean());
     case BinaryOp::Greater:
         return greater(lhs_result, rhs_result);
     case BinaryOp::Smaller:
@@ -232,7 +232,7 @@ Value UnaryExpression::execute(Interpreter& interpreter) const
     case UnaryOp::BitNot:
         return bit_not(lhs_result);
     case UnaryOp::Not:
-        return Value(!lhs_result.as_bool());
+        return Value(!lhs_result.to_boolean());
     }
 
     ASSERT_NOT_REACHED();