LibCore: Fix link_file inverting src and dst paths on duplicate names

File::link_file takes the dst_path then the src_path so on duplicate names we tried to create a link at the original file location, which then flipped the parameters back round again and we ended up with a broken link from "dst_path (1)" to "src_path (1)".
Author: https://github.com/callumwalker 🔰 Commit: https://github.com/SerenityOS/serenity/commit/fd3735199b3 Pull-request: https://github.com/SerenityOS/serenity/pull/9966
2021-09-11 15:39:57 +01:00 · 2021-09-11 15:39:57 +01:00 · fd3735199b · 2024-07-18 04:12:22 +09:00
commit fd3735199b
parent 19de6bb1cc
1 changed files with 1 additions and 1 deletions
--- a/Userland/Libraries/LibCore/File.cpp
+++ b/Userland/Libraries/LibCore/File.cpp
@ -497,7 +497,7 @@ Result<void, OSError> File::link_file(String const& dst_path, String const& src_
        ++duplicate_count;
    }
    if (duplicate_count != 0) {
-        return link_file(src_path, get_duplicate_name(dst_path, duplicate_count));
+        return link_file(get_duplicate_name(dst_path, duplicate_count), src_path);
    }
    int rc = symlink(src_path.characters(), dst_path.characters());
    if (rc < 0) {