0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibJS: Switch objects to unique shape after 100 property additions

Browse source 
At that point, it seems unlikely that the shape is gonna be shared with
other objects, and we avoid getting stuck holding a big bag of shapes.
This commit is contained in:
Andreas Kling 2020-05-05 18:48:30 +02:00
parent e73ad78ba6
commit fc5d0a1bd2
Notes: sideshowbarker 2024-07-19 06:56:55 +09:00
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibJS/Runtime/Object.cpp
View file

@ -212,6 +212,12 @@ bool Object::put_own_property(Object& this_object, const FlyString& property_nam
bool new_property = !metadata.has_value();
if (new_property) {
if (!m_shape->is_unique() && shape().property_count() > 100) {
// If you add more than 100 properties to an object, let's stop doing
// transitions to avoid filling up the heap with shapes.
ensure_shape_is_unique();
}
if (m_shape->is_unique()) {
m_shape->add_property_to_unique_shape(property_name, attributes);
m_storage.resize(m_shape->property_count());