LibWeb: Only return initialized navigables from child_navigables()

Fixes a crash in `get_session_history_entries()` that happens when it attempts to find entries for a navigable that hasn't been fully initialized and therefore doesn't have a nested history entry yet.
Author: https://github.com/kalenikaliaksandr Commit: https://github.com/SerenityOS/serenity/commit/fbc95440a4 Pull-request: https://github.com/SerenityOS/serenity/pull/21093
2023-09-01 22:13:30 +02:00 · 2023-09-01 22:13:30 +02:00 · fbc95440a4 · 2024-07-17 07:14:09 +09:00
commit fbc95440a4
parent 15d265da65
1 changed files with 2 additions and 0 deletions
--- a/Userland/Libraries/LibWeb/HTML/Navigable.cpp
+++ b/Userland/Libraries/LibWeb/HTML/Navigable.cpp
@ -62,6 +62,8 @@ Vector<JS::Handle<Navigable>> Navigable::child_navigables() const
 {
    Vector<JS::Handle<Navigable>> results;
    for (auto& entry : all_navigables()) {
+        if (entry->current_session_history_entry()->step == SessionHistoryEntry::Pending::Tag)
+            continue;
        if (entry->parent() == this)
            results.append(entry);
    }