We use cookies to ensure you get the best experience on our website
首頁 探索 說明
註冊 登入
0ct0pu5
/
ladybird
1
0
複刻 0
Files 問題管理 0 合併請求 0 Wiki
瀏覽代碼

LibWeb: Remove LegacyOverrideBuiltIns flag from Storage

This was preventing https://ubereats.com/ from fully loading, because
they are attempting to overwrite setItem. They seem to be trying to add
error logging to setItem if it throws, as all they do is add a
try/catch block that emits an error log to their monitoring service if
it throws.

However, because Storage is a legacy platform object with a named
property setter (setItem), it will call setItem with the stringified
version of the function. This is actually expected as per the spec,
Firefox (Gecko) and Epiphany (WebKit) does this too, but Chromium does
not as it actually overwrites the function with the new function and
does not store the stringified function.

The problem is that we had the LegacyOverrideBuiltIns flag accidentally
set, so it would return the stored string instead of the built-in
function (hence the name), then it would try and call it and throw a
"not a function" error. This prevented their JS from going any further.

This fix allows their UI to fully load and be fully interactive, though
it is quite slow at the moment!
Luke Wilde 8 月之前
父節點
70ce8046c3
當前提交
faf6fd1189
共有 3 個文件被更改，包括 24 次插入 和 1 次删除
統一視圖 顯示文件統計
  1. 0 1
      Libraries/LibWeb/HTML/Storage.cpp
  2. 10 0
      Tests/LibWeb/Text/expected/HTML/storage-does-not-have-legacy-override-builtins-flag.txt
  3. 14 0
      Tests/LibWeb/Text/input/HTML/storage-does-not-have-legacy-override-builtins-flag.html

+ 0 - 1
Libraries/LibWeb/HTML/Storage.cpp
查看文件 

@@ -28,7 +28,6 @@ Storage::Storage(JS::Realm& realm)
 
         .has_indexed_property_setter = true,
 
         .has_indexed_property_setter = true,
 
         .has_named_property_setter = true,
 
         .has_named_property_setter = true,
 
         .has_named_property_deleter = true,
 
         .has_named_property_deleter = true,
 
-        .has_legacy_override_built_ins_interface_extended_attribute = true,
 
         .indexed_property_setter_has_identifier = true,
 
         .indexed_property_setter_has_identifier = true,
 
         .named_property_setter_has_identifier = true,
 
         .named_property_setter_has_identifier = true,
 
         .named_property_deleter_has_identifier = true,
 
         .named_property_deleter_has_identifier = true,

+ 10 - 0
Tests/LibWeb/Text/expected/HTML/storage-does-not-have-legacy-override-builtins-flag.txt
查看文件 

@@ -0,0 +1,10 @@
 
+key should still be native: 'function key() { [native code] }'
 
+key's stringified function was added to storage: 'function () { println(`FAIL: Overriden ${functionName} was called`); }'
 
+getItem should still be native: 'function getItem() { [native code] }'
 
+getItem's stringified function was added to storage: 'function () { println(`FAIL: Overriden ${functionName} was called`); }'
 
+setItem should still be native: 'function setItem() { [native code] }'
 
+setItem's stringified function was added to storage: 'function () { println(`FAIL: Overriden ${functionName} was called`); }'
 
+removeItem should still be native: 'function removeItem() { [native code] }'
 
+removeItem's stringified function was added to storage: 'function () { println(`FAIL: Overriden ${functionName} was called`); }'
 
+clear should still be native: 'function clear() { [native code] }'
 
+clear's stringified function was added to storage: 'function () { println(`FAIL: Overriden ${functionName} was called`); }'

+ 14 - 0
Tests/LibWeb/Text/input/HTML/storage-does-not-have-legacy-override-builtins-flag.html
查看文件 

@@ -0,0 +1,14 @@
 
+<!DOCTYPE html>
 
+<script src="../include.js"></script>
 
+<script>
 
+    test(() => {
 
+        for (const functionName of ["key", "getItem", "setItem", "removeItem", "clear"]) {
 
+            const failFunction = function () { println(`FAIL: Overriden ${functionName} was called`); };
 
+            window.localStorage[functionName] = failFunction;
 
+
 
+            println(`${functionName} should still be native: '${window.localStorage[functionName].toString()}'`);
 
+            println(`${functionName}'s stringified function was added to storage: '${window.localStorage.getItem(functionName)}'`);
 
+            window.localStorage[functionName]("1", "2");
 
+        }
 
+    });
 
+</script>

Contact | Legal | Takedown | Status
Self-hosted public services - About
NibbleSpot by 0ct0pu5