LibGUI: Simplify AboutDialog::version_string()

No behavior change.
Author: https://github.com/nico Commit: https://github.com/SerenityOS/serenity/commit/faa2c74b49e Pull-request: https://github.com/SerenityOS/serenity/pull/9426 Reviewed-by: https://github.com/linusg ✅
2021-08-14 18:50:10 -04:00 · 2021-08-14 18:50:10 -04:00 · faa2c74b49 · 2024-07-18 05:42:46 +09:00
commit faa2c74b49
parent a45b6dbc07
1 changed files with 3 additions and 11 deletions
--- a/Userland/Libraries/LibGUI/AboutDialog.cpp
+++ b/Userland/Libraries/LibGUI/AboutDialog.cpp
@ -95,19 +95,11 @@ String AboutDialog::version_string() const
    auto version_config = Core::ConfigFile::open("/res/version.ini");
    auto major_version = version_config->read_entry("Version", "Major", "0");
    auto minor_version = version_config->read_entry("Version", "Minor", "0");
-    auto git_version = version_config->read_entry("Version", "Git", "");

    StringBuilder builder;
-    builder.append("Version ");
-    builder.append(major_version);
-    builder.append('.');
-    builder.append(minor_version);
-
-    if (git_version != "") {
-        builder.append(".g");
-        builder.append(git_version);
-    }
-
+    builder.appendff("Version {}.{}", major_version, minor_version);
+    if (auto git_version = version_config->read_entry("Version", "Git", ""); git_version != "")
+        builder.appendff(".g{}", git_version);
    return builder.to_string();
 }