0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-13 18:00:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Kernel: Halt CPU on deadly UBSAN instead of calling PANIC

Browse source 
The separate backtrace that the PANIC emits isn't useful and just adds
more data to visually filter from the output when debugging an issue.
Instead of calling PANIC, just emit the message with dbgln() and
manually halt the system.
This commit is contained in:
Brian Gianforcaro 2021-05-14 22:51:09 -07:00 committed by Andreas Kling
parent db78331741
commit f982ef0ef0
Notes: sideshowbarker 2024-07-18 18:07:39 +09:00 
Author: https://github.com/bgianfo
Commit: https://github.com/SerenityOS/serenity/commit/f982ef0ef09
Pull-request: https://github.com/SerenityOS/serenity/pull/7125
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Kernel/UBSanitizer.cpp
View file

@ -5,8 +5,8 @@
*/ */
#include <AK/Format.h> #include <AK/Format.h>
#include <Kernel/Arch/x86/CPU.h>
#include <Kernel/KSyms.h> #include <Kernel/KSyms.h>
#include <Kernel/Panic.h>
#include <Kernel/UBSanitizer.h> #include <Kernel/UBSanitizer.h>
using namespace Kernel; using namespace Kernel;
@ -24,8 +24,10 @@ static void print_location(const SourceLocation& location)
dbgln("KUBSAN: at {}, line {}, column: {}", location.filename(), location.line(), location.column()); dbgln("KUBSAN: at {}, line {}, column: {}", location.filename(), location.line(), location.column());
} }
dump_backtrace(); dump_backtrace();
if (g_ubsan_is_deadly) if (g_ubsan_is_deadly) {
PANIC("UB is configured to be deadly."); dbgln("UB is configured to be deadly, halting the system.");
Processor::halt();
}
} }
void __ubsan_handle_load_invalid_value(const InvalidValueData&, ValueHandle) __attribute__((used)); void __ubsan_handle_load_invalid_value(const InvalidValueData&, ValueHandle) __attribute__((used));