mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-12-11 17:00:37 +00:00
Kernel: Mark cloned volatile purgeable AnonymousVMOjects as purged
Our existing AnonymousVMObject cloning flow contains an optimization wherein purgeable VMObjects which are marked volatile during the clone are created as a new zero-filled VMObject (as if it was purged), which lets us skip the expensive COW process. Unfortunately, one crucial part was missing: Marking the cloned region as purged, (which is the value returned from madvise when unmarking the region as volatile) so the userland logic was left unaware of the effective zero-ing of their memory region, resulting in odd behaviour and crashes in places like our malloc's large allocation support.
This commit is contained in:
parent
1f88046bb2
commit
f972eda7ed
Notes:
sideshowbarker
2024-07-17 07:11:12 +09:00
Author: https://github.com/IdanHo Commit: https://github.com/SerenityOS/serenity/commit/f972eda7ed Pull-request: https://github.com/SerenityOS/serenity/pull/22384 Issue: https://github.com/SerenityOS/serenity/issues/22334
1 changed files with 1 additions and 0 deletions
|
@ -24,6 +24,7 @@ ErrorOr<NonnullLockRefPtr<VMObject>> AnonymousVMObject::try_clone()
|
|||
// object, effectively "pre-purging" it in the child process.
|
||||
auto clone = TRY(try_create_purgeable_with_size(size(), AllocationStrategy::None));
|
||||
clone->m_volatile = true;
|
||||
clone->m_was_purged = true;
|
||||
return clone;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue