Revert "AK: Remove virtual destructors from non-virtual classes"

This reverts commit 4378d36f67.
Author: https://github.com/IdanHo Commit: https://github.com/SerenityOS/serenity/commit/f90c224fc58 Pull-request: https://github.com/SerenityOS/serenity/pull/6577
2021-04-23 11:10:23 +03:00 · 2021-04-23 11:10:23 +03:00 · f90c224fc5 · 2024-07-18 19:13:01 +09:00
commit f90c224fc5
parent bf9c04a3da
2 changed files with 4 additions and 2 deletions
--- a/AK/IntrusiveRedBlackTree.h
+++ b/AK/IntrusiveRedBlackTree.h
@ -17,7 +17,7 @@ template<Integral K, typename V, IntrusiveRedBlackTreeNode<K> V::*member>
 class IntrusiveRedBlackTree : public BaseRedBlackTree<K> {
 public:
    IntrusiveRedBlackTree() = default;
-    ~IntrusiveRedBlackTree()
+    virtual ~IntrusiveRedBlackTree() override
    {
        clear();
    }
--- a/AK/RedBlackTree.h
+++ b/AK/RedBlackTree.h
@ -33,10 +33,12 @@ public:
            : key(key)
        {
        }
+        virtual ~Node() {};
    };

 protected:
    BaseRedBlackTree() = default; // These are protected to ensure no one instantiates the leaky base red black tree directly
+    virtual ~BaseRedBlackTree() {};

    void rotate_left(Node* subtree_root)
    {
@ -416,7 +418,7 @@ template<Integral K, typename V>
 class RedBlackTree : public BaseRedBlackTree<K> {
 public:
    RedBlackTree() = default;
-    ~RedBlackTree()
+    virtual ~RedBlackTree() override
    {
        clear();
    }