Kernel: Harden DevPtsFSInode::traverse_as_directory against OOM

Use the try variants of AK::StringBuilder append APIs to harden this function against OOM.
Author: https://github.com/bgianfo Commit: https://github.com/SerenityOS/serenity/commit/f8ad3cc6a09 Pull-request: https://github.com/SerenityOS/serenity/pull/11785 Reviewed-by: https://github.com/awesomekling Reviewed-by: https://github.com/creator1creeper1
2022-01-09 02:59:20 -08:00 · 2022-01-09 02:59:20 -08:00 · f8ad3cc6a0 · 2024-07-17 21:07:44 +09:00
commit f8ad3cc6a0
parent 787bfcc530
1 changed files with 3 additions and 2 deletions
--- a/Kernel/FileSystem/DevPtsFS.cpp
+++ b/Kernel/FileSystem/DevPtsFS.cpp
@ -114,9 +114,10 @@ ErrorOr<void> DevPtsFSInode::traverse_as_directory(Function<ErrorOr<void>(FileSy
    TRY(callback({ "..", identifier(), 0 }));

    return SlavePTY::all_instances().with([&](auto& list) -> ErrorOr<void> {
+        StringBuilder builder;
        for (SlavePTY& slave_pty : list) {
-            StringBuilder builder;
-            builder.appendff("{}", slave_pty.index());
+            builder.clear();
+            TRY(builder.try_appendff("{}", slave_pty.index()));
            TRY(callback({ builder.string_view(), { fsid(), pty_index_to_inode_index(slave_pty.index()) }, 0 }));
        }
        return {};