ソースを参照

LibWeb: Specify snake case names for navigation timing entries too

This will be used by performance.measure to read the value of a given
entry in the NavigationTiming interface.
Luke Wilde 2 年 前
コミット
f62bcba56a

+ 2 - 2
Userland/Libraries/LibWeb/NavigationTiming/EntryNames.cpp

@@ -8,7 +8,7 @@
 
 namespace Web::NavigationTiming::EntryNames {
 
-#define __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(name) FlyString name;
+#define __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(name, _) FlyString name;
 ENUMERATE_NAVIGATION_TIMING_ENTRY_NAMES
 #undef __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME
 
@@ -17,7 +17,7 @@ ErrorOr<void> initialize_strings()
     static bool s_initialized = false;
     VERIFY(!s_initialized);
 
-#define __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(name) \
+#define __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(name, _) \
     name = TRY(#name##_fly_string);
     ENUMERATE_NAVIGATION_TIMING_ENTRY_NAMES
 #undef __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME

+ 23 - 23
Userland/Libraries/LibWeb/NavigationTiming/EntryNames.h

@@ -10,30 +10,30 @@
 
 namespace Web::NavigationTiming::EntryNames {
 
-#define ENUMERATE_NAVIGATION_TIMING_ENTRY_NAMES                          \
-    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(navigationStart)            \
-    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(unloadEventStart)           \
-    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(unloadEventEnd)             \
-    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(redirectStart)              \
-    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(redirectEnd)                \
-    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(fetchStart)                 \
-    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(domainLookupStart)          \
-    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(domainLookupEnd)            \
-    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(connectStart)               \
-    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(connectEnd)                 \
-    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(secureConnectionStart)      \
-    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(requestStart)               \
-    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(responseStart)              \
-    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(responseEnd)                \
-    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(domLoading)                 \
-    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(domInteractive)             \
-    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(domContentLoadedEventStart) \
-    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(domContentLoadedEventEnd)   \
-    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(domComplete)                \
-    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(loadEventStart)             \
-    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(loadEventEnd)
+#define ENUMERATE_NAVIGATION_TIMING_ENTRY_NAMES                                                          \
+    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(navigationStart, navigation_start)                          \
+    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(unloadEventStart, unload_event_start)                       \
+    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(unloadEventEnd, unload_event_end)                           \
+    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(redirectStart, redirect_start)                              \
+    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(redirectEnd, redirect_end)                                  \
+    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(fetchStart, fetch_start)                                    \
+    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(domainLookupStart, domain_lookup_start)                     \
+    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(domainLookupEnd, domain_lookup_end)                         \
+    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(connectStart, connect_start)                                \
+    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(connectEnd, connect_end)                                    \
+    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(secureConnectionStart, secure_connection_start)             \
+    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(requestStart, request_start)                                \
+    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(responseStart, response_start)                              \
+    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(responseEnd, response_end)                                  \
+    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(domLoading, dom_loading)                                    \
+    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(domInteractive, dom_interactive)                            \
+    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(domContentLoadedEventStart, dom_content_loaded_event_start) \
+    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(domContentLoadedEventEnd, dom_content_loaded_event_end)     \
+    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(domComplete, dom_complete)                                  \
+    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(loadEventStart, load_event_start)                           \
+    __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(loadEventEnd, load_event_end)
 
-#define __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(name) extern FlyString name;
+#define __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(name, _) extern FlyString name;
 ENUMERATE_NAVIGATION_TIMING_ENTRY_NAMES
 #undef __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME
 

+ 2 - 2
Userland/Libraries/LibWeb/UserTiming/PerformanceMark.cpp

@@ -34,8 +34,8 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<PerformanceMark>> PerformanceMark::construc
     if (is<HTML::Window>(current_global_object)) {
         bool matched = false;
 
-#define __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(name)   \
-    if (mark_name == NavigationTiming::EntryNames::name) \
+#define __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME(name, _) \
+    if (mark_name == NavigationTiming::EntryNames::name)  \
         matched = true;
         ENUMERATE_NAVIGATION_TIMING_ENTRY_NAMES
 #undef __ENUMERATE_NAVIGATION_TIMING_ENTRY_NAME