0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibWeb: Print more information about thrown DOMExceptions in the console

Browse source 
This doesn't quite match the behavior of other engines, but by golly is
it helpful.
This commit is contained in:
Andrew Kaster 2024-03-20 06:43:17 -06:00 • committed by Tim Flynn
parent 6783a524d0
commit f26dd29b4d
Notes: sideshowbarker 2024-07-16 19:17:47 +09:00
3 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Tests/LibWeb/Text/expected/Crypto/SubtleCrypto-generateKey.txt
View file

@ -10,6 +10,6 @@ privateKey type: private
privateKey extractable: true
privateKey usages: decrypt,unwrapKey
invalid usages throw
Error: [object DOMException]
Error: SyntaxError: Invalid key usage 'sign'
no usages for private key throws
Error: [object DOMException]
Error: SyntaxError: usages must not be empty

2
Tests/LibWeb/Text/expected/abortsignal-abort.txt
View file

@ -1,4 +1,4 @@
Aborted: true
Reason: "[object DOMException]"
Reason: "AbortError: Aborted without reason"
Aborted: true
Reason: "This is a test"

11
Userland/Libraries/LibWeb/HTML/Scripting/ExceptionReporter.cpp
View file

@ -11,6 +11,7 @@
#include <LibJS/Runtime/Value.h>
#include <LibWeb/Bindings/MainThreadVM.h>
#include <LibWeb/HTML/Scripting/ExceptionReporter.h>
#include <LibWeb/WebIDL/DOMException.h>
namespace Web::HTML {
@ -25,11 +26,19 @@ void report_exception_to_console(JS::Value value, JS::Realm& realm, ErrorInPromi
auto message = object.get_without_side_effects(vm.names.message).value_or(JS::js_undefined());
if (name.is_accessor() || message.is_accessor()) {
// The result is not going to be useful, let's just print the value. This affects DOMExceptions, for example.
dbgln("\033[31;1mUnhandled JavaScript exception{}:\033[0m {}", error_in_promise == ErrorInPromise::Yes ? " (in promise)" : "", JS::Value(&object));
if (is<WebIDL::DOMException>(object)) {
auto const& exception = static_cast<WebIDL::DOMException const&>(object);
dbgln("\033[31;1mUnhandled JavaScript exception{}:\033[0m {}: {}", error_in_promise == ErrorInPromise::Yes ? " (in promise)" : "", exception.name(), exception.message());
} else {
dbgln("\033[31;1mUnhandled JavaScript exception{}:\033[0m {}", error_in_promise == ErrorInPromise::Yes ? " (in promise)" : "", JS::Value(&object));
}
} else {
dbgln("\033[31;1mUnhandled JavaScript exception{}:\033[0m [{}] {}", error_in_promise == ErrorInPromise::Yes ? " (in promise)" : "", name, message);
}
if (is<JS::Error>(object)) {
// FIXME: We should be doing this for DOMException as well
// https://webidl.spec.whatwg.org/#js-DOMException-specialness
// "Additionally, if an implementation gives native Error objects special powers or nonstandard properties (such as a stack property), it should also expose those on DOMException objects."
auto const& error_value = static_cast<JS::Error const&>(object);
dbgln("{}", error_value.stack_string(JS::CompactTraceback::Yes));
console.report_exception(error_value, error_in_promise == ErrorInPromise::Yes);