0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibJS: Add EnvironmentRecord::global_object()

Browse source 
Our environment records are currently weird in that they inherit from
Object, but don't have a connection to the global object.

I'd like to remove this inheritance, and the first step is giving them
their own pointer to the global object.
This commit is contained in:
Andreas Kling 2021-06-23 12:29:12 +02:00
parent 9d49a5478a
commit f1e1d9dd74
Notes: sideshowbarker 2024-07-18 11:37:58 +09:00
3 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Runtime/EnvironmentRecord.cpp
View file

@ -15,6 +15,12 @@ EnvironmentRecord::EnvironmentRecord(EnvironmentRecord* outer_environment)
{
}
void EnvironmentRecord::initialize(GlobalObject& global_object)
{
m_global_object = &global_object;
Base::initialize(global_object);
}
void EnvironmentRecord::visit_edges(Visitor& visitor)
{
Base::visit_edges(visitor);

8
Userland/Libraries/LibJS/Runtime/EnvironmentRecord.h
View file

@ -19,6 +19,11 @@ class EnvironmentRecord : public Object {
JS_OBJECT(EnvironmentRecord, Object);
public:
GlobalObject& global_object() { return *m_global_object; }
GlobalObject const& global_object() const { return *m_global_object; }
virtual void initialize(GlobalObject&) override;
virtual Optional<Variable> get_from_environment_record(FlyString const&) const = 0;
virtual void put_into_environment_record(FlyString const&, Variable) = 0;
virtual bool delete_from_environment_record(FlyString const&) = 0;
@ -44,6 +49,9 @@ protected:
virtual void visit_edges(Visitor&) override;
private:
virtual bool is_environment_record() const final { return true; }
GlobalObject* m_global_object { nullptr };
EnvironmentRecord* m_outer_environment { nullptr };
};

1
Userland/Libraries/LibJS/Runtime/Object.h
View file

@ -108,6 +108,7 @@ public:
virtual bool is_global_object() const { return false; }
virtual bool is_proxy_object() const { return false; }
virtual bool is_native_function() const { return false; }
virtual bool is_environment_record() const { return false; }
virtual bool is_global_environment_record() const { return false; }
virtual bool is_declarative_environment_record() const { return false; }
virtual bool is_function_environment_record() const { return false; }