0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

SystemMonitor: Ignore unveil error about unexisting HackStudio binary

Browse source 
The minimal build configuration doesn't include HackStudio and
SystemMonitor refused to run after trying to unveil a not exiting file.

This change will just ignore this specific error for this specific file
as if nothing really happened.

The ability to quickly debug a process in HackStudio is not the main
feature of the application and HackStudio itself is rather heavy to be
put in the minimal configuration.

Additionally, I find it unnecessary to disable/hide the 'Debug in
HackStudio' action because build configurations are mostly for testing
purposes anyway. You will get a 'No such file or directory' error in the
console after activating the action though. :^)
This commit is contained in:
Karol Kosek 2023-05-21 21:40:39 +02:00 • committed by Jelle Raaijmakers
parent a041f1671c
commit f12dc8b7f5
Notes: sideshowbarker 2024-07-17 04:21:32 +09:00
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Userland/Applications/SystemMonitor/main.cpp
View file

@ -265,7 +265,9 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
return result.release_error();
TRY(Core::System::unveil("/bin/Profiler", "rx"));
TRY(Core::System::unveil("/bin/HackStudio", "rx"));
// HackStudio doesn't exist in the minimal build configuration.
if (auto result = Core::System::unveil("/bin/HackStudio", "rx"); result.is_error() && result.error().code() != ENOENT)
return result.release_error();
TRY(Core::System::unveil(nullptr, nullptr));
StringView args_tab = "processes"sv;