From ec16556fea7657c6d4ecbcd4848dff49eaee99cc Mon Sep 17 00:00:00 2001 From: Dan Klishch Date: Sat, 9 Mar 2024 16:40:18 -0500 Subject: [PATCH] JSSpecCompiler: Add option to silence all diagnostics and use in tests In the future, we will probably want to test regressions in diagnostics too but let's not do that for now. --- Meta/Lagom/Tools/CodeGenerators/JSSpecCompiler/main.cpp | 6 +++++- Tests/JSSpecCompiler/test-runner.cpp | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Meta/Lagom/Tools/CodeGenerators/JSSpecCompiler/main.cpp b/Meta/Lagom/Tools/CodeGenerators/JSSpecCompiler/main.cpp index 1e247568634..963275875ab 100644 --- a/Meta/Lagom/Tools/CodeGenerators/JSSpecCompiler/main.cpp +++ b/Meta/Lagom/Tools/CodeGenerators/JSSpecCompiler/main.cpp @@ -116,6 +116,9 @@ ErrorOr serenity_main(Main::Arguments arguments) StringView passes_to_dump_cfg; args_parser.add_option(passes_to_dump_cfg, "Dump CFG after specified passes.", "dump-cfg", 0, "{all|last||-[,...]}"); + bool silence_diagnostics = false; + args_parser.add_option(silence_diagnostics, "Silence all diagnostics.", "silence-diagnostics", 0); + args_parser.parse(arguments); CompilationPipeline pipeline; @@ -163,7 +166,8 @@ ErrorOr serenity_main(Main::Arguments arguments) } } - translation_unit.diag().print_diagnostics(); + if (!silence_diagnostics) + translation_unit.diag().print_diagnostics(); return 0; } diff --git a/Tests/JSSpecCompiler/test-runner.cpp b/Tests/JSSpecCompiler/test-runner.cpp index 86afb463924..603f0f48407 100644 --- a/Tests/JSSpecCompiler/test-runner.cpp +++ b/Tests/JSSpecCompiler/test-runner.cpp @@ -92,6 +92,8 @@ Vector build_command_line_arguments(LexicalPath const& test_source, if (test_source.has_extension(".cpp"sv)) result.append("-xc++"sv); + result.append("--silence-diagnostics"sv); + result.append(test_source.string()); return result;