فهرست منبع

Userland: Use Core::File::read_link()

Sergey Bugaev 5 سال پیش
والد
کامیت
eb7af00152
2فایلهای تغییر یافته به همراه8 افزوده شده و 9 حذف شده
  1. 5 6
      Userland/ls.cpp
  2. 3 3
      Userland/test_io.cpp

+ 5 - 6
Userland/ls.cpp

@@ -33,6 +33,7 @@
 #include <LibCore/ArgsParser.h>
 #include <LibCore/ArgsParser.h>
 #include <LibCore/DateTime.h>
 #include <LibCore/DateTime.h>
 #include <LibCore/DirIterator.h>
 #include <LibCore/DirIterator.h>
+#include <LibCore/File.h>
 #include <ctype.h>
 #include <ctype.h>
 #include <dirent.h>
 #include <dirent.h>
 #include <errno.h>
 #include <errno.h>
@@ -208,13 +209,11 @@ size_t print_name(const struct stat& st, const String& name, const char* path_fo
     }
     }
     if (S_ISLNK(st.st_mode)) {
     if (S_ISLNK(st.st_mode)) {
         if (path_for_link_resolution) {
         if (path_for_link_resolution) {
-            char linkbuf[PATH_MAX];
-            ssize_t nread = readlink(path_for_link_resolution, linkbuf, sizeof(linkbuf) - 1);
-            if (nread < 0) {
-                perror("readlink failed");
+            auto link_destination = Core::File::read_link(path_for_link_resolution);
+            if (link_destination.is_null()) {
+                perror("readlink");
             } else {
             } else {
-                linkbuf[nread] = '\0';
-                nprinted += printf(" -> ") + print_escaped(linkbuf);
+                nprinted += printf(" -> ") + print_escaped(link_destination.characters());
             }
             }
         } else {
         } else {
             nprinted += printf("@");
             nprinted += printf("@");

+ 3 - 3
Userland/test_io.cpp

@@ -27,6 +27,7 @@
 #include <AK/Assertions.h>
 #include <AK/Assertions.h>
 #include <AK/LogStream.h>
 #include <AK/LogStream.h>
 #include <AK/Types.h>
 #include <AK/Types.h>
+#include <LibCore/File.h>
 #include <fcntl.h>
 #include <fcntl.h>
 #include <stdio.h>
 #include <stdio.h>
 #include <string.h>
 #include <string.h>
@@ -212,9 +213,8 @@ void test_unlink_symlink()
         ASSERT_NOT_REACHED();
         ASSERT_NOT_REACHED();
     }
     }
 
 
-    char buffer[PATH_MAX];
-    rc = readlink("/tmp/linky", buffer, sizeof(buffer));
-    ASSERT(rc == strlen("/proc/2/foo"));
+    auto target = Core::File::read_link("/tmp/linky");
+    ASSERT(target == "/proc/2/foo");
 
 
     rc = unlink("/tmp/linky");
     rc = unlink("/tmp/linky");
     if (rc < 0) {
     if (rc < 0) {