0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibPthread: Don't set errno in pthread functions

Browse source 
POSIX says that pthread API's don't set errno directly. If there is an
error, it should be the return value from the function instead.
This commit is contained in:
Andreas Kling 2019-12-07 14:33:18 +01:00
parent babb726212
commit eaab7f5672
Notes: sideshowbarker 2024-07-19 10:56:34 +09:00
1 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
Libraries/LibPthread/pthread.cpp
View file

@ -24,8 +24,7 @@ extern "C" {
static int create_thread(void* (*entry)(void*), void* argument, void* stack)
{
int rc = syscall(SC_create_thread, entry, argument, stack);
__RETURN_WITH_ERRNO(rc, rc, -1);
return syscall(SC_create_thread, entry, argument, stack);
}
static void exit_thread(void* code)
@ -83,8 +82,7 @@ void pthread_exit(void* value_ptr)
int pthread_join(pthread_t thread, void** exit_value_ptr)
{
int rc = syscall(SC_join_thread, thread, exit_value_ptr);
__RETURN_WITH_ERRNO(rc, rc, -1);
return syscall(SC_join_thread, thread, exit_value_ptr);
}
int pthread_mutex_init(pthread_mutex_t* mutex, const pthread_mutexattr_t* attributes)
@ -413,10 +411,9 @@ int pthread_cond_timedwait(pthread_cond_t* cond, pthread_mutex_t* mutex, const s
while (node.waiting) {
struct timespec now;
if (clock_gettime(condvar.clock, &now) < 0)
return -1;
return errno;
if ((abstime->tv_sec < now.tv_sec) || (abstime->tv_sec == now.tv_sec && abstime->tv_nsec <= now.tv_nsec)) {
errno = ETIMEDOUT;
return -1;
return ETIMEDOUT;
}
pthread_mutex_unlock(mutex);
sched_yield();