Browse Source

LibGUI: Return symlink fallback icon if target icon cannot be determined

This is the case for symlinks that point to themselves, for example -
previously the returned icon would be empty.

Fixes #5978.
Fixes #5979.
Linus Groh 4 years ago
parent
commit
e8aa998cdc
1 changed files with 2 additions and 0 deletions
  1. 2 0
      Userland/Libraries/LibGUI/FileIconProvider.cpp

+ 2 - 0
Userland/Libraries/LibGUI/FileIconProvider.cpp

@@ -235,6 +235,8 @@ Icon FileIconProvider::icon_for_path(const String& path, mode_t mode)
             target_path = Core::File::real_path_for(String::formatted("{}/{}", LexicalPath(path).dirname(), raw_symlink_target));
         }
         auto target_icon = icon_for_path(target_path);
+        if (target_icon.sizes().is_empty())
+            return s_symlink_icon;
 
         Icon generated_icon;
         for (auto size : target_icon.sizes()) {